Repository navigation
ci: add frontmatter lint workflow (expected red until #128 merges) - #134
Merged
Merged
Conversation
Parses YAML frontmatter of plugin/commands/*/SKILL.md, plugin/skills/*/SKILL.md and .claude/commands/*.md; fails on parse errors, non-string argument-hint, missing name/description. Refs #129.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 22, 2026
lis186
added a commit
that referenced
this pull request
Oct 22, 2026
…137) * ci: add frontmatter lint workflow (expected red until #128 merges) (#134) * ci: add frontmatter lint workflow (Tier 1) Parses YAML frontmatter of plugin/commands/*/SKILL.md, plugin/skills/*/SKILL.md and .claude/commands/*.md; fails on parse errors, non-string argument-hint, missing name/description. Refs #129. * ci(lint): only treat column-0 --- as frontmatter delimiter (cherry picked from commit e3c7d6c) * ci: also run verify on push to feature/skill-slim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做什麼
新增第一個 CI(VERIFICATION.md §9 Tier 1 的
lint-frontmatter):.github/workflows/verify.yml:pull_request與 push 到main觸發,permissions: contents: read,不用任何 secret。tests/tools/lint-frontmatter.py(+lint-frontmatter.shwrapper):用 PyYAMLsafe_load解析plugin/commands/*/SKILL.md、plugin/skills/*/SKILL.md、.claude/commands/*.md的 frontmatter。argument-hint但不是字串 → fail(Skills fail to load in GitHub Copilot CLI 1.0.65+ due to array-shapedargument-hint#129 的根因)description必須是非空字串;SKILL.md的name必須是非空字串.claude/commands/*.md的name為選填(Claude Code 由檔名推得,現有檔案都沒有),有的話必須是字串path: reason,最後印N files checked, F files failed (P problems);有失敗 exit 1,找不到任何檔案 exit 2(防止在錯的目錄跑)這個 PR 不修任何指令檔,那是 #128 的工作。
在目前的 main 上,這個 CI 預期會紅燈,而且應該剛好抱怨下面 11 個檔案(就是 #128 修的那些)。等 #128 合併後轉綠。
本機在 main(b176ae0)上的輸出,exit 1:
本機套用 #128 head(af28b44)之後,exit 0:
另外在 /tmp 做過負向測試:argument-hint 是 list、缺 description、frontmatter 沒有結尾
---、SKILL.md 缺 name、在錯的目錄執行,都會觸發對應的錯誤。建議合併順序
#128 來自外部 fork,
pull_requestworkflow 要等這個檔進了 main 才會在 fork PR 上跑,而且首次貢獻者可能要維護者按 "Approve and run"。建議:先合這個 PR(紅燈是預期的),再讓 #128 rebase 或重跑 CI 確認綠燈後合併,main 就會轉綠。Refs #129