Skip to content

ci: add frontmatter lint workflow to feature/skill-slim (from #134) - #137

Merged
lis186 merged 2 commits into
feature/skill-slimfrom
ci/skill-slim-verify
Oct 22, 2026
Merged

lis186 merged 2 commits into
feature/skill-slimfrom
ci/skill-slim-verify

Conversation

@lis186

@lis186 lis186 commented Oct 22, 2026

Copy link
Copy Markdown
Owner

做什麼

把 main 上 #134 的 frontmatter lint CI 帶到 feature/skill-slim(cherry-pick 合併 commit e3c7d6c,三個檔與 main 逐字相同,日後 skill-slim 合回 main 不會衝突):

  • .github/workflows/verify.yml
  • tests/tools/lint-frontmatter.py
  • tests/tools/lint-frontmatter.sh

pull_request 觸發原本就沒有限制 base branch,所以以 feature/skill-slim 為 base 的 PR(例如 #136)都會跑。另外在 push.branches 加上 feature/skill-slim,讓合併後 skill-slim 本身也有 CI。

Source: #134. Refs #135, #136.

預期紅燈

這個 PR 上 lint-frontmatter 預期會紅:skill-slim 目前有 10 個檔的 argument-hint 沒加引號,修正在 #136。預期失敗清單正好是:

  • .claude/commands/atlas.{deps,flow,impact,overview,pattern,reset}.md
  • plugin/commands/{deps,flow,impact,reset}/SKILL.md

和 #134 的前例一樣:先合 CI,再把 skill-slim 更新進 #136,#136 綠燈後合併。

)

* ci: add frontmatter lint workflow (Tier 1)

Parses YAML frontmatter of plugin/commands/*/SKILL.md, plugin/skills/*/SKILL.md and .claude/commands/*.md; fails on parse errors, non-string argument-hint, missing name/description. Refs #129.

* ci(lint): only treat column-0 --- as frontmatter delimiter

(cherry picked from commit e3c7d6c)
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T06:48:00.379386Z 00d55ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lis186

lis186 commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

驗收:workflow 在 PR 上觸發(run 39736207200 @00d55ad、39736322522 @763091c),兩次都是預期紅燈,失敗清單正好是 #136 修的 10 個檔(24 files checked, 10 files failed)。依 #134 前例 squash merge,接著把 skill-slim 更新進 #136。

@lis186
lis186 merged commit 0ddbee2 into feature/skill-slim Oct 22, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant