Skip to content

fix(frontmatter): quote argument-hint values on skill-slim (#135 A) - #136

Merged
lis186 merged 2 commits into
feature/skill-slimfrom
fix/skill-slim-argument-hint
Oct 22, 2026
Merged

lis186 merged 2 commits into
feature/skill-slimfrom
fix/skill-slim-argument-hint

Conversation

@lis186

@lis186 lis186 commented Oct 22, 2026

Copy link
Copy Markdown
Owner

做什麼

#135 主題 A:feature/skill-slim 上的 argument-hint 沒加引號,不是合法的 YAML 字串(以 [ 開頭會被當成 flow sequence,含 : 會被當成 mapping),Copilot CLI 1.0.65+ 因此載入失敗。做法跟 #128 一樣:每個檔只改 argument-hint 那一行,引號內文字與原值逐字相同(含雙引號的值用單引號包,兩個 reset 用雙引號包)。

Refs #135, #128

改了哪些檔(10 個,各 1 行)

範圍先用 PyYAML 掃過 skill-slim 所有含 frontmatter 的 .md(含 commands、SKILL.md、proposals):解析失敗的只有這 10 個。#135 原本列的 history 在 skill-slim 上是 (optional) [...],PyYAML 與 Copilot CLI 都能正確解析成字串,不需要改;pattern 的 SKILL.md 已經加過引號。

驗收

1. Lint(main 上 #134 的 tests/tools/lint-frontmatter.py,PyYAML)

Tree 結果
origin/feature/skill-slim(daa3066) FAIL,exit 1:24 files checked, 10 files failed(就是這 10 個)
本 PR(e06ff4e) PASS,exit 0:24 files checked, 0 files failed (0 problems)

另外逐檔確認:10 個 argument-hint 都解析成 str,且等於原本未加引號的文字。git diff --stat:10 files changed, 10 insertions(+), 10 deletions(-)。

2. Copilot CLI 載入(1.0.101,隔離 HOME、無 token,把 plugin/commands/{deps,flow,history,impact,reset} 放進暫存專案的 .github/skills/ 後跑 copilot skill list)

  • skill-slim 原狀:只載入 history;deps、flow、impact、reset 列在 "failed to load"(failed to parse YAML frontmatter)。
  • 本 PR:deps、flow、history、impact、reset 五個都列在 Project skills。

3. E2E 對 flask(pallets/flask @ d086db8,照 #128 驗證的方式跑各 skill 的決定性步驟,base 與 PR tree 各跑一次)

Skill 指令/步驟 輸出摘要 base vs PR
flow wsgi_app:SKILL.md STEP 2 的 grep -rn "wsgi_app" --include=*.py src/ app/ lib/ src/flask/app.py:1566 def wsgi_app( 等 4 筆 相同
deps werkzeug:搜 pyproject.toml 與 from/import werkzeug pyproject.toml:29 "werkzeug>=3.1.0" 及 src imports,33 行 相同
impact Flask:搜 Python references src/flask/__init__.py 匯出、sansio/scaffold.py 等 20 筆 相同
reset 無參數(all):在暫存目錄執行 Step 1 與 Step 4 的 rm -rf .sourceatlas/* 清除前 deps/flows/history.md/impact/overview.yaml/patterns;清除後為空 相同
(overview helper) scripts/atlas/detect-project.sh 偵測為 Python 相同

限制:沒有 Copilot/Claude 的登入 token,所以沒有跑 LLM 分析、也沒有產出完整報告,只驗證 skill 能被載入,以及資料收集步驟的輸出不變。這個 PR 只改 frontmatter,不影響 skill 內文。

CI

feature/skill-slim 上沒有 .github/workflows/(verify.yml 是 #134 加在 main 的),所以這個 PR 不會有 CI check。

Same fix as #128: unquoted argument-hint values starting with [ or
containing ': ' are not valid YAML strings, so Copilot CLI 1.0.65+ fails
to load deps/flow/impact/reset. Only the argument-hint line changes in
each file; hint text is unchanged.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T06:42:25.506689Z e06ff4e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lis186

lis186 commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

CI 更新:#137 已把 lint workflow 帶到 feature/skill-slim。合入 base(f0f2887)後 lint-frontmatter run 39736409868 綠燈(24 files checked, 0 failed)。內文「不會有 CI check」那段已不適用。

@lis186
lis186 merged commit 7a697be into feature/skill-slim Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant