Repository navigation
fix(frontmatter): quote argument-hint values on skill-slim (#135 A) - #136
Merged
Merged
Conversation
Same fix as #128: unquoted argument-hint values starting with [ or containing ': ' are not valid YAML strings, so Copilot CLI 1.0.65+ fails to load deps/flow/impact/reset. Only the argument-hint line changes in each file; hint text is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ll-slim-argument-hint
Owner
Author
|
CI 更新:#137 已把 lint workflow 帶到 feature/skill-slim。合入 base(f0f2887)後 |
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做什麼
#135 主題 A:
feature/skill-slim上的argument-hint沒加引號,不是合法的 YAML 字串(以[開頭會被當成 flow sequence,含:會被當成 mapping),Copilot CLI 1.0.65+ 因此載入失敗。做法跟 #128 一樣:每個檔只改argument-hint那一行,引號內文字與原值逐字相同(含雙引號的值用單引號包,兩個 reset 用雙引號包)。Refs #135, #128
改了哪些檔(10 個,各 1 行)
plugin/commands/{deps,flow,impact,reset}/SKILL.md.claude/commands/atlas.{deps,flow,impact,overview,pattern,reset}.md(這 6 行與 fix(commands): quote argument-hint values for Copilot CLI 1.0.65 YAML parser #128 對 main 的修改逐字相同,日後 main 合回 skill-slim 時不會衝突)範圍先用 PyYAML 掃過 skill-slim 所有含 frontmatter 的
.md(含 commands、SKILL.md、proposals):解析失敗的只有這 10 個。#135 原本列的history在 skill-slim 上是(optional) [...],PyYAML 與 Copilot CLI 都能正確解析成字串,不需要改;pattern的 SKILL.md 已經加過引號。驗收
1. Lint(main 上 #134 的
tests/tools/lint-frontmatter.py,PyYAML)origin/feature/skill-slim(daa3066)另外逐檔確認:10 個
argument-hint都解析成str,且等於原本未加引號的文字。git diff --stat:10 files changed, 10 insertions(+), 10 deletions(-)。2. Copilot CLI 載入(1.0.101,隔離 HOME、無 token,把
plugin/commands/{deps,flow,history,impact,reset}放進暫存專案的.github/skills/後跑copilot skill list)history;deps、flow、impact、reset列在 "failed to load"(failed to parse YAML frontmatter)。deps、flow、history、impact、reset五個都列在 Project skills。3. E2E 對 flask(
pallets/flask@ d086db8,照 #128 驗證的方式跑各 skill 的決定性步驟,base 與 PR tree 各跑一次)wsgi_app:SKILL.md STEP 2 的grep -rn "wsgi_app" --include=*.py src/ app/ lib/src/flask/app.py:1566 def wsgi_app(等 4 筆werkzeug:搜pyproject.toml與from/import werkzeugpyproject.toml:29 "werkzeug>=3.1.0"及 src imports,33 行Flask:搜 Python referencessrc/flask/__init__.py匯出、sansio/scaffold.py等 20 筆rm -rf .sourceatlas/*scripts/atlas/detect-project.sh限制:沒有 Copilot/Claude 的登入 token,所以沒有跑 LLM 分析、也沒有產出完整報告,只驗證 skill 能被載入,以及資料收集步驟的輸出不變。這個 PR 只改 frontmatter,不影響 skill 內文。
CI
feature/skill-slim上沒有.github/workflows/(verify.yml是 #134 加在 main 的),所以這個 PR 不會有 CI check。