Repository navigation
Conversation
Startup errors for an absent or unreadable app-config secret now name the reference key, never its value. The startup tests poison every legacy name with valid values, ignore Linux self-connections in the before-listen probe and check logs for secret values after successful runs too. DataDome leaves Host and Protocol out of the protection payload when the checked request information fails, instead of reporting an unchecked header or request target. The provider acceptance script runs through a symlink, asserts the cause of each startup failure without printing output, and pins container DNS.
The getting-started Axum quickstart exported legacy config and secret variables that the production startup ignores, so following it failed. It now uses the local config directory and EDGEZERO__SECRETS__ values. The Axum guides describe the binary as the production entry point, and the native startup guide is written for operators with a run-locally example. CI runs the provider acceptance helper tests; the full Docker run stays local.
A secret reference key is an operator-supplied string. If a secret value were pasted into a reference field, an error naming the key would log it. Startup errors now name the config field paths that reference the missing secret, using a new core secret_reference_paths helper, and the tests and smoke script assert that no key appears. The architecture guide now describes Axum's prepared-store snapshots, and the integration environment attaches Axum's recent output when readiness times out.
4 tasks
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc/identityat9d02d7b3(no RC tag, no cutover of its own), so the rebase and repin parts of the issue are done there. This PR does the rest of A1 and answers the Extract native prepared startup on the demo baseline #1531 review threads that still apply.ec.passphrase), never the reference key or the value. A key is an operator-supplied string, so a secret pasted into a reference field would otherwise be logged. The startup and acceptance tests are tightened: legacy names are poisoned with valid values, the before-listen probe ignores self-connections, and logs are checked for secret values after successful runs too.Changes
crates/trusted-server-adapter-axum/src/startup.rsNativeStoreSnapshotispub(crate).read_only_config/read_only_secretmerged intoread_only_snapshot(see note below)crates/trusted-server-adapter-axum/src/app.rscrates/trusted-server-adapter-axum/Cargo.toml,Cargo.locktemp-envdev-dependency removedcrates/trusted-server-adapter-axum/tests/startup.rsrequired snapshot missingwith every legacy name poisoned by a valid envelope; distinctive short passphrase; secret-in-logs check after successful runs; rename to..._while_running;reserve_portcomments; should-messagescrates/trusted-server-adapter-axum/tests/native_acceptance.rs/actionrequests; distinctive short passphrase and success-path log checks;reserve_portcomments; should-messagescrates/trusted-server-core/src/secret_resolution.rs,crates/trusted-server-core/src/config_payload.rssecret_reference_paths/required_secret_references: each required key with the config paths that reference it, for diagnostics. Unit testcrates/trusted-server-core/src/integrations/datadome/protection.rsHost/Protocolinstead of falling back to the raw header or URI target. New red/green testcrates/trusted-server-integration-tests/tests/environments/axum.rsscripts/test-native-providers.mjsimport.meta.main(works through a symlink);agent: false; self-connect guard; failure launches capture output in memory and assert the cause and absence of secret values without printing;--dns 127.0.0.1;DOCKER_HOSTpass-throughscripts/tests/test-native-providers.test.mjsscripts/smoke-axum.sh.github/workflows/format.yml,AGENTS.mdnode --test 'scripts/tests/*.test.mjs'; gate list entrydocs/guide/getting-started.mdts config push --adapter axum --local,EDGEZERO__ADAPTER__CONFIG_DIRandEDGEZERO__SECRETS__*; legacy env table removeddocs/guide/native-rc-demo.md,docs/guide/axum-dev.md,docs/guide/api-reference.md,docs/guide/architecture.md,crates/trusted-server-adapter-axum/README.md,docs/.vitepress/config.mtsdocs/superpowers/specs/2026-11-19-axum-production-serving-design.md,docs/superpowers/plans/2026-11-19-axum-production-serving.mdAcceptance status (#1573)
scripts/test-native-providers.mjspasses locally against moto and the AppConfig agent (Docker). CI runs only its helper unit testsTS_*,TRUSTED_SERVER_CONFIG_*,TRUSTED_SERVER_SECRET_*TS_GIT_VERSIONis a build-time constantTRUSTED_SERVER__overridests config push, never read at runtime. The CI guard is A9 (#1580)rc/identity9d02d7b3#1531 review threads
import.meta.main(thread 11); missing-config test asserts the exact diagnostic and poisons every legacy name with valid values (thread 12); truncated-POST test asserts exactly three/actionrequests (thread 20); native guide rewritten for operators, sidebar entry, run-locally block (thread 23);agent: false(thread 27); DataDome omitsHost/Protocolwhen checked request info fails, on all adapters, instead of reporting the unchecked rawHostor request target (thread 32; the thread offered rejecting or omitting, and omitting keeps the protection request);reserve_portcomments (thread 33); getting-started quickstart rewritten (it previously failed; D-2); CI job for the provider helper tests and AGENTS.md gate entry (A-7);temp-envremoved (A-9); distinctive short passphrase and secret-in-logs checks after successful runs (A-10); failure launches assert the cause without printing output (A-12);--dns 127.0.0.1andDOCKER_HOSTpass-through (A-13;DOCKER_CONTEXTis intentionally not passed becauseHOMEis isolated); rename to..._while_running(A-14);NativeStoreSnapshotispub(crate)(A-18); should-messages on touched assertions (A-21); integration environment attaches a bounded output tail on pre-readiness exit (A-23); missing-secret diagnostics name the secret's config path, asserted per secret in Rust tests andsmoke-axum.sh, with no reference key printed (derived from thread 8; naming the key itself could print a secret pasted into a reference field).discovery_route_status_parityrequires Axum to match. Native startup already rejectsrequest_signing.enabled.send_async, eager dispatch, budget tests, proxy marker) is gone and outbound goes through EdgeZero'sHttpClient; Spinstartup.rsand the Fastlydelivery_tests.rsare gone; oversized bodies map to 413 in core; the EdgeZero pin is arev, not a tag; SIGTERM drain is already covered byproduction_sigterm_drains_the_admitted_publisher_response.rustls,ctutils) are present on the stack base (A-26).Note:
read_only_config/read_only_secretwere merged intoread_only_snapshotbecause CodeQL flagged the old helper name as a cleartext-logging source on #1528 (rust/cleartext-logging, rotation rollback log). CodeQL only runs on PRs tomain, so this PR cannot show the alert gone.Self-review
An independent review of the implementation found no blocking issues. Its three optional findings are fixed in
6949eea86: name config paths instead of reference keys in the missing-secret error, update the Axum section of the architecture guide, and attach the output tail on the integration readiness deadline.Closes
Part of #1573. Not
Closes: #1531 carries most of A1, and the pending-record-write item belongs to A3/A8.Spec
Spec: docs/superpowers/specs/2026-11-19-axum-production-serving-design.md (ends with a three-round review log)
Test plan
Full gates, run locally on the code before the self-review fix commit
6949eea86; hosted CI covers that commit:cargo test-fastly && cargo test-axum(alsotest-fastly-reusewith Viceroy 0.21.0,test-cloudflare,test-spin)cargo clippy-fastly && cargo clippy-axum(alsoclippy-cloudflare,clippy-cloudflare-wasm,clippy-spin-native,clippy-spin-wasm,clippy-cli,clippy-codegen, and thetemplate_build_digestclippy)cargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servetemplate_build_digesttestnative_acceptancetests; integration-tests clippy;node --test 'scripts/tests/*.test.mjs'(7 pass);./scripts/smoke-axum.shscripts/test-native-providers.mjsagainst a release binary with both AWS features, moto and the AppConfig agent; every PASS line, including the selected config and secret failures before listenChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)