Repository navigation
Conversation
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test-native-ec-image.mjsfrom #1536) #1579.Stack: based on #1635 (
feat/1573-axum-production-serving), which is stacked on #1531. The other current open branches do not supply a more appropriate A3 base. This does not require waiting for those reviews or merges.Temporary dependency — must repin before merge: all six EdgeZero dependencies and
Cargo.lockpinb256e5b1da9c3b61b661e039a680e1afeb4bfe23on preview/r2-after-response. This is the clean merge ofrc/identityat9d02d7b3with IABTechLab/edgezero#509 ata5c176e1; no new EdgeZero implementation changes. Replace this preview pin with R2 (IABTechLab/edgezero#490) before merging. The preview is not R2.Changes
Cargo.toml,Cargo.lockcrates/trusted-server-core/src/ec/after_response.rscrates/trusted-server-core/src/settings.rscrates/trusted-server-adapter-fastly/src/app.rs,src/post_delivery.rscrates/trusted-server-adapter-axum/src/app.rs,src/after_response.rs,src/lib.rscrates/trusted-server-adapter-axum/src/after_response/tests.rs,Cargo.tomldocs/guide/edgezero.md,docs/guide/native-rc-demo.mdCloses
Closes #1575 with the following explicit acceptance boundary, matching #1573's staged approach:
scripts/test-native-ec-image.mjsfrom #1536) #1579. This PR adds no record store and does not manufacture permits without a successful page phase.Spec
Design · Plan
Two independent design/plan review rounds completed; all blocking and optional feedback resolved. Independent implementation review also completed. Two fresh self-reviewers found no blocking production defects; their shared assertion/reporting precision finding was corrected by enforcing strict successful shutdown bounds and rerunning the affected tests. Both verified the correction on the final head: zero unresolved blocking or optional findings.
Test plan
Final reviewed head:
53650c24264f919f6ba18aebb0690a5b5f1ca866; base:6949eea868adc9427f965f984d9ea049e4b36f69.Full local CI intentionally not run, as requested. After the reported failure, CI on
4ee94f8b7was inspected: both failing jobs (cargo test (cross-adapter parity)andintegration tests) stopped at the same stale identity-guard exception for Fastly's former directcommit_after_response_lookupscall. The call moved to core in this PR;53650c242removes its obsolete pending-migration exception while retaining the forbidden-symbol check.The std-only identity-guard test source was reproduced locally with Rust 1.98.1: 8 passed/1 failed before the correction, then all 9 passed with
-D warnings. A disposable negative control reintroducing the direct Fastly call was rejected. Rust formatting, changed-line domain lint and an independent review also passed. This targeted validation usedrustc --testwith the actual crate'sCARGO_MANIFEST_DIR; the Cargo integration suite and full local CI were not rerun. New-head CI remains pending/unassessed, and the R2 repin is still required before merge.cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkfastly compute serve: not runcargo clippy-axum; targeted native core lib and Fastly all-target/all-feature clippy passed.Runtime evidence: the subprocess fixture uses the real EdgeZero production host and the same Axum scheduling helper. Its live row and guarded store are test-only; the real pull-sync coordinator consumes a scripted provider response. A separate actual SDK HTTP call from the runner's post-response row read verifies the fresh outbound scope. This qualifies the infrastructure; it does not qualify deployed record persistence or a real partner HTTPS integration.
The control skips registration: response drain succeeds while lookup/write completion disappears. Additional tests exercise shared request/task grace, independent task-budget cancellation and client disconnect. Ordinary operator-path serving and response drain are tested separately from fixture activation. Real Chrome through the publisher proxy executed injected TSJS on candidate and exact #1635 base. During a publisher request, candidate completed a 1.45 MB response and exited 0 in 3.288 s of a 5 s grace; exact #1635 control exited 0 in 3.151 s. Image 404s and analytics 411s reproduced on the base. The operator smoke used a private compatibility projection with unsupported identity-only Prebid behavior, auctions and request signing disabled; it does not certify those features. All original local files were restored exactly; no operator
trusted-server.tomlor.envedits.The registered-task fixture separately proves response completion before the guarded write and successful exit strictly within its 2 s grace. Skipping registration removes the lookup/write while preserving response drain. With 450 ms spent on a held response and an 850 ms task, the 1 s shared grace cancels the write; it does not grant another task grace. Task-budget cancellation and disconnect release also pass.
EdgeZero qualification: all 10 selected after-response tests, format and targeted Axum clippy passed on the preview tree. Four broader native proxy/TLS hosting tests fail locally (including serial rerun):
native_selected_families_conflicts_malformed_sets_gaps_and_exhaustion,native_source_bound_single_proxy_and_mapped_cidr_match_only_owned_peers, andnative_two_proxy_chain_stops_at_untrusted_hop_and_gateway_replaces_prefixfail at the response-head check incrates/edgezero-adapter-axum/tests/production_hosting.rs:394;native_verified_tls_ingress_overwrites_public_assertions_and_rejects_wrong_namereports an unexpected TLS EOF at line 875. Attribution is unresolved. The preview adds only four test-file changes over the previous pin, with no EdgeZero runtime-code delta. No EdgeZero implementation fix was attempted or added here.Checklist
unwrap(); useslogmacros