Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime_env!validates constant names during metadata-only checks.feat/1573-axum-production-serving). Independent of Drain after-response tasks on SIGTERM #1575; no Axum startup, shutdown or after-response changes.Changes
scripts/lint-runtime-env.sh,scripts/clippy-runtime-env/clippy.tomlscripts/test-runtime-env.shcrates/trusted-server-core/src/runtime_env.rs,src/lib.rssrc/{app,middleware,platform}.rs, coresrc/integrations/datadome.rsbuild.rs.github/workflows/format.yml,AGENTS.mdCloses
Closes #1580
Spec
Runtime environment guard design
Implementation plan
Test plan
scripts/test-runtime-env.sh: 38 fixtures pass; test-first controls showed the unchecked legacy read and unchecked macro were accepted before enforcement.scripts/lint-runtime-env.sh: all four production targets pass, including separate default and reusable-sandbox Fastly checks with Rust/Clippy 1.98.1 and Node 24.20.0.TRUSTED_SERVER_CONFIG_POISONread on a disposable source copy with the expected policy lint at the read site.cargo test --locked -p trusted-server-adapter-axum --test startup: 8 pass, including prepared-store loading and legacy poison rejection.cargo test --locked -p trusted-server-core --lib protection_test_bypass: 9 pass.cargo test --locked -p trusted-server-adapter-fastly --target wasm32-wasip1 version_header: 4 pass under Viceroy 0.21.0.cargo clippy --locked -p trusted-server-core --lib -- -D warnings,cargo fmt --all -- --check, shellcheck for both new scripts, targeted Markdown formatting, and the workflow Node-pin guard.modeinput. Operator config and environment files remain untouched; owned server stopped.Checklist
fa4a1a0285edd8a01ed3d2bf8fedc3d1057c8b88: no remaining blocking or optional findings; description reconciled