[adamjohnwright]

Lint ratchet: @typescript-eslint/no-non-null-assertion, first area. This removes all 52 non-null assertions from the GSA form library (projects/reactome-gsa-form).

What changed

A dataset in the store fills in as it loads: first its summary, then its annotations, then its statistical design. Each reader now states what it needs, instead of asserting that the data is there.

• Reducer.
  • A change to a design goes through updateDesign, and a change made from a summary goes through fromSummary. Before the dataset has a design or summary, both leave the state as it is. The entity helper already does the same for a dataset that does not exist.
  • Annotation columns are made only for datasets that have annotations.
• Selectors. Each reads the design once, and treats a missing design as "not complete". Before, loadingStatus!.status threw when the status was absent.
• Submitting. The request's design is built by submittedDesign, which is exported and tested.
  • A design missing its comparison groups, or naming a covariate that has no column, is refused through the same path a refused request takes (loadFailure, with the reason shown). Before, it was sent without them for the service to refuse.
  • The form requires a complete design before it submits, so this path is not expected to fire.
  • Request.Dataset and Request.DataInformation are exported so the function can be typed.
• Loading. A finished load with no dataset id now fails the same way as a summary that could not be fetched. Before, it requested /summary/undefined.
• Dataset sources. The source selector compares type only when it exists. The ! on id was unnecessary, because id is required.

Counts

	Before	After
Lint	1,129	1,077
no-non-null-assertion	203	151
Dead code	104	104

Tested

• Unit: the new submittedDesign spec covers a complete design, a design missing its groups, and a covariate with no column. I removed the comparison-group check and it failed.
• End-to-end: analysis.spec.ts and analysis-results.spec.ts, which include the GSA form: 33 passed.
• Preflight: passed in full on push.

Note for review

This branch was cut before #895 merged. Both PRs touch lint-baseline.json, so whichever merges second needs its baseline regenerated; I'll rebase this one once #895 is in.

🤖 Generated with Claude Code

[adamjohnwright]

Independent review, with main merged in: no regression that matters; the state shape is unchanged.

Acted on (5388605, both tests seen failing under mutation):

• A design whose analysis group or chosen covariate names a column the samples lack now says which column, instead of only "not complete". The default analysis group comes from the service, not the annotation header, so the form can show such a design as complete.
• The client-side refusal is built by refusal() and tested as a 400 with its reason in detail. A 503 would be retried every minute as the service being busy.

Left as they are, all on paths the form's steps do not reach in normal use:

• A load with no dataset id now goes straight to getSummaryError without the 10 s snackbar. Nothing reads that action's error today.
• The reducer's new no-op paths (updateDesign, fromSummary, initAnnotationColumns) replace code that fabricated partial state or threw, and have no tests of their own.

The lint baseline is regenerated after the merge: 931 → 879 warnings.

🤖 Generated with Claude Code