Repository navigation
e2e: the tissue drag follows the page, not the clock - #928
Merged
Merged
Conversation
'a dragged tissue counts as chosen' failed three times in one CI run. Its trace shows why: the test measured the selected list while the analysis panel was still opening, the panel then pushed the form down about 170px, and the drop landed on the heading above the list. The drag also relied on fixed pauses (150 ms, then 20 ms a step). The drag now waits on what the page shows: pressed on Colon as it is now until CDK's preview carries it, then moved to the selected list as it is now until CDK's placeholder is in it, re-measured if the page moved, and released only then. No fixed pause is left. Checked: 24 of 24 runs eight at once with the browser's CPU slowed sixfold. Aimed off the list, the old test releases and fails as CI did; the new one does not release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky end-to-end test
a dragged tissue counts as chosen(e2e/analysis-results.spec.ts), which failed three times in one CI run on #896. No spec: a test fix.Cause, from CI's trace: the test measured the selected list while the analysis panel was still opening. The panel then pushed the form down about 170 px, and the drop landed on the heading above the list. The drag also relied on fixed pauses (150 ms, then 20 ms a step).
Now the drag waits on what the page shows, with no fixed pause:
Checked:
🤖 Generated with Claude Code