Repository navigation
Conversation
A test can now prove which scenario a fake camera is playing before it asserts on it. The four tests that need a live camera on 127.0.0.1:8443 get the integration marker.
…o.json scenario.json gains an expected block (alerts, sequences, location, timeout_s), validated offline by tests/test_scenarios.py. tests/e2e waits for the first alert, then for every fake camera to finish, and compares what the API returns with that block. Tests that need Postgres or S3 get the integration marker so the offline suite passes with no stack.
Fresh stack, in-repo images built, engine and front profiles up, then the e2e tests. The exit code is kept and the compose logs, ps and junit go to e2e-artifacts/. The three images with no arm64 manifest are pinned to linux/amd64 so the stack starts on Apple Silicon.
Writes the frames into <camera>/<preset>/ and takes the sequence seen on the pose whose patrol_id is that preset. Without --preset nothing changes.
A preset plays <scenario>/<camera>/<preset>/*.jpg when the folder exists and falls back to the camera-level frames, so the existing scenarios are unchanged. finished now waits for every preset declared in poses, and GET /scenario reports visits, frame and frames per preset. The e2e never-polled abort keys on those visits.
Preset 3 of croix-augas-01 plays 18 frames of prod alert 49767 then a clear frame, the six other poses hold one clear frame. Expected: one alert, one sequence on that pose. SCENARIOS_URL can now be overridden, so the images can be fetched from another release.
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#52 asks for a baseline: smoke on one camera, one alert. Today every preset of a fake camera plays the same frames ->
smoke-then-cleargives 5 alerts and 7 sequences for one fire (#72). Hard to assert "one alert" on that.What this adds
<scenario>/<camera>/<preset>/NNN.jpg, folder name = key ofposes. No folder -> the camera-level<camera>/*.jpg, so the 3 existing scenarios are unchanged.finishedwaits for every preset declared inposes(before: the visited ones).GET /scenarioadds apresetsblock: visits, frame and frames per preset.make_scenario.py --preset 3writes<camera>/3/from the sequence seen on that pose.smoke-one-camera: preset 3 ofcroix-augas-01plays 18 frames of prod alert 49767 then a clear frame, the 6 other poses hold a clear frame.SCENARIOS_URLcan be overridden formake fetch-scenario.Example
What reached the API after that run:
pose_id10 = preset 3. The block the tests read:Checks
pytest tests --ignore=tests/e2e -m "not integration"make e2e SCENARIO=smoke-one-camera, run 1pyro_camera_apiand the enginepyro_camera_apistopped after its first patrolmake fetch-scenariofrom the release on my forkSingle runs on an arm64 Mac, app images under amd64 emulation.
Before merging
smoke-one-camera.zip(3.2 MB) to thescenariosrelease of this repo, I can't upload here. It is in the same release on my fork. Until then:make e2e SCENARIO=smoke-one-camera SCENARIOS_URL=https://github.com/Acruve15/pyro-envdev/releases/download/scenarios.Open points
min_detections= 7, half of the 14 measured. Both runs ran with 3, I raised it after.Closes #52.