Repository navigation
Conversation
A test can now prove which scenario a fake camera is playing before it asserts on it. The four tests that need a live camera on 127.0.0.1:8443 get the integration marker.
…o.json scenario.json gains an expected block (alerts, sequences, location, timeout_s), validated offline by tests/test_scenarios.py. tests/e2e waits for the first alert, then for every fake camera to finish, and compares what the API returns with that block. Tests that need Postgres or S3 get the integration marker so the offline suite passes with no stack.
Fresh stack, in-repo images built, engine and front profiles up, then the e2e tests. The exit code is kept and the compose logs, ps and junit go to e2e-artifacts/. The three images with no arm64 manifest are pinned to linux/amd64 so the stack starts on Apple Silicon.
Writes the frames into <camera>/<preset>/ and takes the sequence seen on the pose whose patrol_id is that preset. Without --preset nothing changes.
A preset plays <scenario>/<camera>/<preset>/*.jpg when the folder exists and falls back to the camera-level frames, so the existing scenarios are unchanged. finished now waits for every preset declared in poses, and GET /scenario reports visits, frame and frames per preset. The e2e never-polled abort keys on those visits.
Preset 3 of croix-augas-01 plays 18 frames of prod alert 49767 then a clear frame, the six other poses hold one clear frame. Expected: one alert, one sequence on that pose. SCENARIOS_URL can now be overridden, so the images can be fetched from another release.
Three read-only tests in tests/e2e/ui on the smoke-one-camera alert: the alert card names the camera, the player image is loaded and is one the API serves for the sequence, the close-up is one of its crops and can be hidden and shown. One login for the session through the real login page, reused through the storage state. make e2e runs the API tests then the browser tests, and make e2e-install installs Chromium.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make e2eonly runs on a laptop. Nothing runs it when pyro-api, the platform or the engine merge, and the old compose workflow is disabled. #55 asks for one reusable workflow here that the three app repos call with their new image.What this adds
docker-compose.yml: the 4 app images become variables (API_IMAGE,PLATFORM_IMAGE,ENGINE_IMAGE,CAMERA_API_IMAGE), full reference so a digest works. Empty ->latest..github/workflows/e2e.yml, one job: pull the images, writeversions.json,make e2e, uploade2e-artifacts/andversions.json.workflow_call,workflow_dispatch, PRs here, nightly at 03:17 UTC (upstream only).envdev_ref(defaultmain).Example
What an app repo adds after its image push:
versions.json, local dry run (shortened, onnever-smoke):{ "images": { "pyro_api": { "reference": "pyronear/alert-api@sha256:0467...0e92", "digest": "pyronear/alert-api@sha256:0467...0e92" }, "frontend": { "reference": "pyronear/pyro-platform-react:latest", "digest": "pyronear/pyro-platform-react@sha256:b5b8...6f34" } }, "envdev_commit": "03f21a7e1e1d922e36bd485ed768770c8ef90a05", "scenario": "never-smoke", "scenario_zip_sha256": "2092...7c2b" }Checks
setup-uv,make initand the image pull pass, then "Record versions.json" stops on the 404 belowe2e.ymlversions.jsonstep, run locally underbash -eo pipefaildocker compose config: no variable, 4 overrides, empty variablemake e2e SCENARIO=smoke-one-camerawithAPI_IMAGEset to a digest, fresh stackapicontainer runs the@sha256referenceLocal runs on an arm64 Mac, amd64 emulation.
Before the first green run
smoke-one-camera.zipin thescenariosrelease here (same ask as feat: one frame folder per preset and the smoke-one-camera baseline #73). Until then the run stops at "Record versions.json" with a 404.pre-commitfails for another reason: no Python 3.9 on theubuntu-latestrunner. Not touched here.Open points
--with-deps, the 45 min timeout and the triggers other thanpull_requestare not proven yet. That run also answers Exploration: run the engine with its model in GitHub CI #54.cancel-in-progress-> a second merge in an app repo cancels the run of the first.issues: writein a called workflow breaks callers that don't grant it.setup-uvpinned tov10.3.3, no movingv10tag.Part of #55.