Skip to content

[Fix]: unclear and false positive warnings + an issue with additional informations targetting same field name over differents items (Glpi 12) - #701

Open
jdurand-teclib wants to merge 3 commits into
mainfrom
fix/47354/error-during-injection-glpi-12
Open

jdurand-teclib wants to merge 3 commits into
mainfrom
fix/47354/error-during-injection-glpi-12

Conversation

@jdurand-teclib

Copy link
Copy Markdown
Contributor

Note

This PR is the Glpi 12 version of #695

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !47354
  • Here is a brief description of what this PR does
    • Change unclear and generic warning messages in the logs into more explicit ones (especially for mapping issues)
    • Added a warning message when attempting to connect an item to a network port results in finding 0 or several ports
    • Fix a false positive warning when creating a network port without requesting it to be attached to a switch (considered as failed and triggered a warning)
    • Fix 2 issues regarding additional informations sharing a field name accross multiple itemtypes
      • they were overwritting eachother (i.e a Memory name overwritting a Processor name, or both having the same name...)
      • The data data injection form was only displaying the names of the fields, and not their itemtype (c.f screenshots)
        Unit tests to cover changes and ensure no regression

Screenshots (if appropriate):

Before solving the field names display issue:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant