[jdurand-teclib]

Note

This PR also exists for Glpi 12. #701

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !47354
• Here is a brief description of what this PR does
  • Change unclear and generic warning messages in the logs into more explicit ones (especially for mapping issues)
  • Added a warning message when attempting to connect an item to a network port results in finding 0 or several ports
  • Fix a false positive warning when creating a network port without requesting it to be attached to a switch (considered as failed and triggered a warning)
  • Fix 2 issues regarding additional informations sharing a field name accross multiple itemtypes
    • they were overwritting eachother (i.e a Memory name overwritting a Processor name, or both having the same name...)
    • The data data injection form was only displaying the names of the fields, and not their itemtype (c.f screenshots)
      Unit tests to cover changes and ensure no regression

Screenshots (if appropriate):

Before solving the field names display issue:

After:

[Lainow]

The ERROR_NAME_NOT_MAPPED message is misleading. The check (inc/commoninjectionlib.class.php:2344) also triggers when the “Description” column is properly mapped but empty in that row. The user then sees “a mapping is needed” and goes looking for a mapping that already exists.

[Lainow]

Once it's fixed, you can open the same PR for version 12 of the GLPI plugin(if you can reproduce the issue there as well), please.

[jdurand-teclib]

Once it's fixed, you can open the same PR for version 12 of the GLPI plugin(if you can reproduce the issue there as well), please.

Thanks for the warning, i'll do it once this one is validated to get the good version

[jdurand-teclib]

The ERROR_NAME_NOT_MAPPED message is misleading. The check (inc/commoninjectionlib.class.php:2344) also triggers when the “Description” column is properly mapped but empty in that row. The user then sees “a mapping is needed” and goes looking for a mapping that already exists.

Since the context doesn't allow to tell a missing mapping from an empty value apart, I updated the message to cover both possibilities, so the user can check both.