Repository navigation
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Since Fields 1.24.7, Fields container classes (
PluginFieldsAbstractContainerInstance) always returnfalseincanCreate()/canUpdate().Because of this, in DataInjection 2.15.12:
checkRightOnModel()).No right to update data (PluginFields...)(effectiveAddOrUpdate()).This PR skips the rights check for Fields container classes. The rights on the parent item (e.g.
Phone) are still checked.Tested on GLPI 11.0.7 / DataInjection 2.15.12 / Fields 1.24.7: the model is visible again and the additional fields are saved.