[thavelin]

Fixes #73.

The route contract now expects GET for List*/Get*/Lookup* and exactly HealthRoutes.Healthcheck, and POST for every other RPC. A mismatch reports the expected method and naming rule. Path violations continue to accumulate independently, and the exception map remains empty.

Regression cases cover valid reads and writes, unrecognized read names, PUT/PATCH/DELETE, the exact Healthcheck exception and lookalikes, and accumulated reasons across routes and prefixes. The request standard documents the enforced naming rule. No production or generated code differs from main.

Validation: focused contract regressions and both Go module test suites passed, as did Go build/vet, protobuf lint/format/public-breaking checks, and formatting/diff checks. Full local make check stopped at Windows path-separator handling in the existing TypeScript entry-point checker. CI runs the complete checks and regeneration on Linux.

[ptmo516]

"write over GET" asserts more than the check knows. isRead only recognises List*/Get*/Lookup* (plus Healthcheck), so a read-only RPC under any other name — say SearchTopics over GET — is reported as a write. Failing closed is right; the message is what's off, since it misdescribes the RPC and doesn't tell the author what to do.

Either of these is a one-string change (plus the expected strings in routes_conformance_test.go):

• Say what the check actually knows: "GET on an RPC not named List*/Get*/Lookup*"
• Or keep the framing and name the remedy: "write over GET (reads are named List*/Get*/Lookup*)"

Related: the AGENTS.md row says List*/Get*/Lookup* use GET, but not that every read must carry one of those names — which is what this check now enforces. If that's intended, worth saying in the row too.

[thavelin]

Fixed in 9cca3d7. The diagnostic now gives the expected method and explains the read naming rule without calling an unrecognized RPC a write. Updated AGENTS.md and added the SearchTopics-over-GET case, keeping the exact HealthRoutes.Healthcheck exception. Focused tests and make test pass locally.

[ptmo516]

Optional, not a blocker.

These three checks can be one. Each RPC has exactly one correct method, so:

want, kind := "POST", "write"
if isRead(r) {
	want, kind = "GET", "read"
}
if r.Method != want {
	reasons[key] = append(reasons[key], kind+" over "+r.Method)
}

• Still enforces "no other methods": anything but the one expected method fails.
• One reason per mistake. Today a read over PUT reports unsupported method: PUT; read over PUT, while a write over PUT reports only unsupported method: PUT and never points at POST. With this, every reason implies its fix.

Cost: the expected strings in routes_conformance_test.go change (unsupported method: X → read over X / write over X). If you're touching the write over GET wording anyway (other comment), it lands on the same lines.

[thavelin]

Simplified this to one expected-method check in 9cca3d7: GET for recognized reads, POST otherwise. Each method mismatch now has one reason, and path errors still accumulate separately. Updated the expectations; focused tests and make test pass locally.

[ptmo516]

Optional. Consider moving these tests into routes_test.go, beside nonConformingRoutes, and dropping this file. go/contract keeps one test file per topic, and "conformance" already names the reusable suites (storetest, sessiontest), which this isn't.

[thavelin]

Moved both regression tests beside nonConformingRoutes in routes_test.go and removed the separate file in 9cca3d7. Tests pass locally.

[ptmo516]

Optional. These rows, and health over OPTIONS, test methods the manifest can't contain: routegen emits only GET/POST/PUT/PATCH/DELETE, uppercase, and fails make gen on anything else (routegen/internal/model/model.go, already tested in describe_test.go). Consider dropping them.

[thavelin]

Dropped those rows, including read-over-HEAD and health-over-OPTIONS, in 9cca3d7. Confirmed routegen already rejects unsupported patterns and tests that boundary. Kept PUT/PATCH/DELETE coverage here. Focused tests and make test pass locally.

[Snowpile]

Approving. Merges cleanly on main, make test passes, and it meets all three of #73's criteria.

Optional cleanups:

• The AGENTS.md row could read "List*/Get*/Lookup* and HealthRoutes.Healthcheck use GET; every other RPC uses POST, so a read must carry one of those names."
• The two expected diagnostics are repeated ~20 times in TestNonConformingRoutes_Methods; two constants would shorten it.
• The doc comment on isRead ("Reads are named for what they do…") was dropped; worth keeping, now with the Healthcheck exception.

[thavelin]

Prepared the three optional cleanups in a separate follow-up to the merged PR: the shorter rule text, an isRead comment covering Healthcheck, and local constants for the repeated test expectations. The 25 regression subcases, manifest check and both-module make test pass locally.

Follow-up: #146.