Repository navigation
Clarify the route method rule and regression expectations - #146
Merged
Merged
Conversation
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #86.
Apply the three optional review cleanups after #86 merged: shorten the request-standard row, restore the
isReadcomment with the exact Healthcheck exception, and name the repeated expected diagnostics inside the method regression test. Classification and diagnostics are unchanged; the test expectations remain independent of the implementation strings.Validation: all 25 regression subcases and the manifest check, both-module
make test, contractgo vet, formatting and diff checks pass locally. Fullmake check, TypeScript, regeneration and downstream Chain checks were not run locally.