Repository navigation
fix(release): separate binary version stamp from published site and unblock stable gate - #185
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 218ec0c66a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Packaging must not advertise an unreleased version on the public website. | ||
| # Promote public-site metadata and download links together after verified publication. | ||
| if ($SkipPublicSite) { | ||
| Write-Host 'Public website metadata left at the currently published version.' | ||
| return |
There was a problem hiding this comment.
The Package workflow now leaves public-site metadata unchanged and requires a separate post-publication promotion, but this commit updates none of the required documentation. Document -SkipPublicSite and the coordinated metadata/download-link promotion in docs/RELEASE_PACKAGING.md, including that the default script invocation still stamps website metadata. Otherwise, maintainers following the documented release process have no instructions for this newly separated step. This violates the root AGENTS.md requirement to update documentation when changing release-script behavior.
AGENTS.md reference: AGENTS.md:L261-L275
Useful? React with 👍 / 👎.
Root cause identified in exact stable Package run
Package #43156582090 was correctly blocked by
PublicReleaseChannelsAndPagesFallbackMirrorAgreebecausestamp-release-version.ps1advanced publicsite/seo-manifest.jsonand HTML metadata to 3.6.8 while existing download buttons still truthfully pointed to published RC.5. The test detected this release-stamping inconsistency. No public stable tag/assets were created.Correct separation of responsibilities
-SkipPublicSiteto version stamping: still stamp exact binaryDirectory.Build.propsidentity, but keep both public site anddocsmirror at the last published version until release is verified.Packageworkflow, leaving manual / field stamping behavior intact.Promotion
Single exact-head CI including Windows and actionlint, then merge to master. Fast-forward
release/stable-3.6.8to the newly merged master commit to trigger a fresh Package run. Publish only on full green Windows WPF/setup/hashes/SBOM/attestation; update website download links in a separate post-publication change.No IEC-101 engine changes; PR #145 remains excluded.