Repository navigation
fix(pages): download newest fully packaged public ArSee installer and ZIP automatically - #186
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88fdac36cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // One release must contain matching installer, ZIP, checksum and SBOM. | ||
| // A half-uploaded stable tag must not replace an already working public RC. | ||
| const current = packages.find((p) => p.installer); | ||
| const stable = packages.find((p) => !p.release.prerelease); |
There was a problem hiding this comment.
Apply the complete-package gate to stable release links
When a newly published stable release contains the ZIP, checksums and SBOM but its installer is still missing, inspect() includes it in packages, so this predicate selects it despite the completeness check used for current. Reproducing that response with v3.6.8 and a complete RC.5 leaves the primary downloads on RC.5 but changes the Download and FAQ stable links to advertise v3.6.8. Require the installer for the stable selection too, so an incomplete stable release is not promoted through the secondary release channel.
Useful? React with 👍 / 👎.
User-facing goal
Landing-page Download buttons must deliver the newest publicly released Windows installer EXE and portable ZIP, not permanently pinned RC.5, and must not advertise the stable release that is still being built in the other workstream.
Implementation
release-download.jsfor English + Indonesian landing, Download and FAQ pages.docs/compatibility mirror with canonicalsite/; do not touch protocol engine or the in-progress stable packaging workflow.Release isolation
This change does not create/publish v3.6.8, advance version numbers or modify the separate #185 stable packaging fix. As soon as stable v3.6.8 is successfully published with all required assets, the same deployed page will resolve it without another hard-coded URL update.
Verification