Repository navigation
Test rhp's charts as a caller meets them - #13
Merged
Merged
Conversation
rhp's charts lost their tests when the twins that compared only the templates Solid's compiler made of them went: since then nothing ran a chart in a browser but the one the hydration tests prerender, so a scale's ticks and a changed row's redraw were not held by any test, and the vault could not name a proof of either at a release. Each is now tested as a caller meets it, in OCaml, against what rhp draws: the rows plotted by their slat, the chart's range and its ticks, and a row whose field changes redrawn in place on the next frame, the others untouched.
A test that runs only in this repository changes nothing a user installs, so it names no version: the charts' tests land with the next release's change, not as one of their own.
The page's install line named 0.11.1, whose asset no release has made.
zaiev
added a commit
that referenced
this pull request
Nov 16, 2026
Nothing ran litany on solidtype, and its first run reported a literal condition at every component tag: the `if false` that holds a tag's props to `Props.check` was written at the tag's own location, so any linter reading the typed tree took it for the user's code. An application on Hypha Stack, whose rules gate runs litany, could not pass with a single component on its page: HAF's MVP run stopped there. This PR completes 0.11.1, beside its change, with #13's tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rhp's charts lost their tests when the twins that compared only the templates Solid's compiler made of them went (#5): since then nothing ran a chart in a browser but the one the hydration tests prerender, so a scale's ticks and a changed row's redraw were held by no test, and the vault could not name a proof of either at a release.
Changes
Verified
make test: vitest's 968, the three new among them;make lint;make docswith no warning.