Skip to content

Release 0.11.1: generated checks are ghost, and lint holds litany - #14

Merged
zaiev merged 3 commits into
mainfrom
release-0-11-1-generated-checks-are-ghost-and-lint-holds-litany
Nov 16, 2026
Merged

zaiev merged 3 commits into
mainfrom
release-0-11-1-generated-checks-are-ghost-and-lint-holds-litany

Conversation

@zaiev

@zaiev zaiev commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

Nothing ran litany on solidtype, and its first run reported a literal condition at every component tag: the if false that holds a tag's props to Props.check was written at the tag's own location, so any linter reading the typed tree took it for the user's code. An application on Hypha Stack, whose rules gate runs litany, could not pass with a single component on its page: HAF's MVP run stopped there. This PR completes 0.11.1, beside its change, with #13's tests.

Changes

  • The if false ppx_solidtype writes around a component's tag is at a ghost location, as ppxlib asks of generated code: a linter no longer reports it.
  • Theme's storage catches the browser's throw alone, Js.Exn.Error, and no longer an OCaml exception raised beside it.
  • make lint runs litany, its default set and the rule on opens; the ppx names Ppxlib's every use through an alias instead of opening it, so no exception is left for an open, and the one exception left, == where identity is the point, is the rule's own case. AGENTS.md keeps only what is solidtype's own.
  • CHANGES.md names 0.11.1, and the install page its plugin.

Verified

  • test/ppx/ghost.ml lowers every JSX form and fails on an if false not at a ghost location: nineteen without the fix, none with it.
  • make test and make lint locally, litany among the lint, with no finding at a component tag.

Nothing ran litany on solidtype, and AGENTS.md restated what Hypha's
rules for a library and for OCaml already say. make lint now runs
litany's default set and its rule on opens, from a litany file naming
each exception with its reason, and AGENTS.md keeps what is
solidtype's own.

Litany's first run reported a literal condition at every component
tag: the if false that holds a tag's props to Props.check was written
at the tag's own location. The deriver now writes it at a ghost
location, as ppxlib asks of code no source holds, so no tool reading
the typed tree takes it for the user's -- an application on Hypha
Stack whose rules gate runs litany could not pass with a single
component on its page. It also found a catch-all around storage that
would swallow an OCaml exception with the browser's throw.
The fix was held only by litany run over solidtype's own code. A test
now lowers every JSX form and fails on an if false not at a ghost
location: it reports nineteen without the fix, none with it. Two
comments that said what the code says are gone.
The ppx and its new test opened Ppxlib under a litany exception, the
one way the rule on opens was not kept. Their names are Ppxlib's through
an alias, as the rule asks, and no exception is left for an open.
@zaiev
zaiev merged commit c361316 into main Nov 16, 2026
2 checks passed
@zaiev
zaiev deleted the release-0-11-1-generated-checks-are-ghost-and-lint-holds-litany branch November 16, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant