Repository navigation
Release 0.11.1: generated checks are ghost, and lint holds litany - #14
Merged
zaiev merged 3 commits intoNov 16, 2026
Merged
Conversation
Nothing ran litany on solidtype, and AGENTS.md restated what Hypha's rules for a library and for OCaml already say. make lint now runs litany's default set and its rule on opens, from a litany file naming each exception with its reason, and AGENTS.md keeps what is solidtype's own. Litany's first run reported a literal condition at every component tag: the if false that holds a tag's props to Props.check was written at the tag's own location. The deriver now writes it at a ghost location, as ppxlib asks of code no source holds, so no tool reading the typed tree takes it for the user's -- an application on Hypha Stack whose rules gate runs litany could not pass with a single component on its page. It also found a catch-all around storage that would swallow an OCaml exception with the browser's throw.
The fix was held only by litany run over solidtype's own code. A test now lowers every JSX form and fails on an if false not at a ghost location: it reports nineteen without the fix, none with it. Two comments that said what the code says are gone.
The ppx and its new test opened Ppxlib under a litany exception, the one way the rule on opens was not kept. Their names are Ppxlib's through an alias, as the rule asks, and no exception is left for an open.
zaiev
deleted the
release-0-11-1-generated-checks-are-ghost-and-lint-holds-litany
branch
November 16, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nothing ran litany on solidtype, and its first run reported a literal condition at every component tag: the
if falsethat holds a tag's props toProps.checkwas written at the tag's own location, so any linter reading the typed tree took it for the user's code. An application on Hypha Stack, whose rules gate runs litany, could not pass with a single component on its page: HAF's MVP run stopped there. This PR completes 0.11.1, beside its change, with #13's tests.Changes
if falseppx_solidtypewrites around a component's tag is at a ghost location, as ppxlib asks of generated code: a linter no longer reports it.Theme's storage catches the browser's throw alone,Js.Exn.Error, and no longer an OCaml exception raised beside it.make lintruns litany, its default set and the rule on opens; the ppx names Ppxlib's every use through an alias instead of opening it, so no exception is left for an open, and the one exception left,==where identity is the point, is the rule's own case.AGENTS.mdkeeps only what is solidtype's own.CHANGES.mdnames 0.11.1, and the install page its plugin.Verified
test/ppx/ghost.mllowers every JSX form and fails on anif falsenot at a ghost location: nineteen without the fix, none with it.make testandmake lintlocally, litany among the lint, with no finding at a component tag.