Repository navigation
fix(health): reject unsupported workout duration units - #89
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workout parsing now treats explicitly unsupported duration units as missing, so their raw values no longer enter summaries as seconds. Supported seconds, minutes and hours units, case variants, omitted-unit defaults and measured zero retain their existing behaviour.
Part of #7. Closes #88.
Verification
mise run lintpassed with 0 serious violations and 491 existing warnings.mise run buildpassed.mise run testpassed, including 23 video-pipeline checks, 169 XCTest tests and 98 Swift Testing tests.swift test --filter WorkoutDurationUnitTestsfailed before the parser fix with 17 expectation failures, demonstrating the regression tests detect the bug.Proof
Core logic test capture succeeded. The before-fix transcript showed an unsupported unit contributing 30 seconds to a weekly total that should contain only a valid 30-minute workout.
The full
mise run testtranscript after the fix shows supported conversions, preserved metadata and child statistics, Codable round trips, measured zero, missing duration in per-workout and weekly CSV/JSON exports, and mixed weekly totals in both input orders.No app screens changed. Simulator and UI captures were not required for this core-only slice; no capture method was blocked.
Reviewer notes
Omitted duration units continue to mean seconds for compatibility. Empty units and unsupported units such as
dayandmsproduce a missing duration, even when start and end dates exist. This slice does not infer elapsed duration from those dates or add conversions for new units. Other ingestion and recommendation work in #7 remains open.