Repository navigation
feat: recommend workouts using catalogue equipment alternatives - #91
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BetterFit now offers
getRecommendedWorkout(from:), which creates the first planned workout using real catalogue exercises when equipment is unavailable. Repeated exercise entries are swapped individually, with catalogue metadata and target sets preserved; the existing no-argument API keeps its generated alternatives.Part of #5. Closes #90.
Verification
mise run lintpassed with 0 serious violations and 491 existing warnings.mise run buildpassed.mise run testpassed with 23 pipeline checks, 169 XCTest tests and 105 Swift Testing tests.git diff origin/main --checkpassed.The branch was rebased onto main after the sweep merged #89 and #87, then all three mise gates were rerun successfully.
Proof
Core logic test capture succeeded. The seven new tests in
CatalogueRecommendationTestsexercise the facade through plan selection, template creation and catalogue swaps. The transcript verifies repeated entries, target sets and stored data, catalogue preference and changing availability, unchanged unmatched entries, current-week selection, five missing-plan/template cases, empty templates and compatibility with the existing API.No app screens changed. Simulator and UI test captures were not required for this core-package slice; no capture method was blocked. Full local gate transcripts are under
.tmp/proof/and are not committed.Verification after merge
On merged main at
c4090af,mise run lint,mise run build,mise run testandgit diff origin/main --checkall passed. Lint reported 491 existing warnings and no serious violations. Build completed in 33.36 seconds. The fresh core-logic capture shows 23 pipeline checks, 169 XCTest tests and 105 Swift Testing tests passing.No app screens changed, so visual captures were not applicable. No capture method was blocked. The initial lint attempt required trusting this worktree with
mise trust; the rerun passed.After merging the metadata-only release PR #92, all three mise gates passed again on main at
54cae9d. Results remained 491 lint warnings with no serious violations, 23 passing pipeline checks, 169 passing XCTest tests and 105 passing Swift Testing tests. The working tree is clean.Reviewer notes
Entries without a catalogue match remain unchanged and may still require unavailable equipment. Callers supply a movement-appropriate catalogue; exact muscle matching alone does not establish movement equivalence. Target weights are preserved, without load conversion. Recovery-based ranking and iOS/watch catalogue wiring remain follow-up slices under #5.