Repository navigation
Add translations for every language Craft ships - #110
Merged
Merged
Conversation
Adds the en source file, which the translation sync needs, moves strings that Craft 5 already translates to the app category, fixes two untranslatable strings, and replaces Crowdin with the translation-sync workflow. Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4 Co-authored-by: Amp <amp@ampcode.com>
- Revision: th ฉบับแก้ไข, pl Wersja, ar النسخة المحفوظة, fa نگارش, is vistuð útgáfa, he גרסה שמורה, hu revízió - ar Class: الصنف (الفئة is Category) - he Draft: טיוטה - tr: straight apostrophes, matching tr app.php - fr: non-breaking spaces before ? : » and after «
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensource file. Without the source file, the translation sync has nothing to read.src/translations/en/webhooks.php(83 strings) and full translations for all 33 languages Craft ships. The existing Chinese translation is now complete, and its Crowdin-era errors are fixed.app.php. Labels were checked against the code where their meaning was ambiguous.app.php(such as “Name”, “Status”, “Pending”, and the group dialogs) now useapp. Everything else useswebhooks.|t('webhook')category on “No requests logged”, and the group settings button's untranslatedtitle.app, and “An unknown error occurred.” (not in Craft) moved towebhooksand is registered./crowdin.ymlline from.gitattributes.enaslinguist-generated=truein.gitattributes(/src/translations/*/webhooks.php, withenexempted), so diffs collapse them and language stats ignore them.## Unreleased.Important
Merge #109 first. This PR adds the workflow, whose daily schedule runs from
3.x. If it runs before4.xhas itsensource file, it prunes the 4.x-only strings from the catalog.Evidence
cms's
.agents/skills/translations/scripts/check.php(withapp.phpswapped forwebhooks.php) flags invalid ICU, dropped placeholders, and keys missing fromen:Craft::t('app', …),|t('app'), and registeredappstring exists in Craft 5'sen/app.php(checked with a script).ecs checkpasses,phpstanreports no errors, andprettier --checkpasses onManage.js.translation-sync sync --fetch --dry-run, run on a local copy with this PR and the4.xPR merged and the catalog ontranslations, reports: