Skip to content

Add translations for every language Craft ships - #110

Merged
brandonkelly merged 3 commits into
3.xfrom
feature/translations-3.x
Nov 21, 2026
Merged

brandonkelly merged 3 commits into
3.xfrom
feature/translations-3.x

Conversation

@brandonkelly

@brandonkelly brandonkelly commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Webhooks had only a partial Chinese translation and no en source file. Without the source file, the translation sync has nothing to read.
  • This adds src/translations/en/webhooks.php (83 strings) and full translations for all 33 languages Craft ships. The existing Chinese translation is now complete, and its Crowdin-era errors are fixed.
    • Terms, register, and quote style follow each language's Craft 5 app.php. Labels were checked against the code where their meaning was ambiguous.
  • Translation category audit:
    • Strings that exist verbatim in Craft 5's app.php (such as “Name”, “Status”, “Pending”, and the group dialogs) now use app. Everything else uses webhooks.
    • Fixed the misspelled |t('webhook') category on “No requests logged”, and the group settings button's untranslated title.
    • JS strings: the group dialogs are now registered under app, and “An unknown error occurred.” (not in Craft) moved to webhooks and is registered.
  • Replaces Crowdin with craftcms/translation-sync: adds the workflow and drops the /crowdin.yml line from .gitattributes.
  • Marks every translation file except en as linguist-generated=true in .gitattributes (/src/translations/*/webhooks.php, with en exempted), so diffs collapse them and language stats ignore them.
  • Adds release notes under ## Unreleased.

Important

Merge #109 first. This PR adds the workflow, whose daily schedule runs from 3.x. If it runs before 4.x has its en source file, it prunes the 4.x-only strings from the catalog.

Evidence

cms's .agents/skills/translations/scripts/check.php (with app.php swapped for webhooks.php) flags invalid ICU, dropped placeholders, and keys missing from en:

each of 33 languages: 83 of 83 translated   (exit 0)
  • Every Craft::t('app', …), |t('app'), and registered app string exists in Craft 5's en/app.php (checked with a script).
  • ecs check passes, phpstan reports no errors, and prettier --check passes on Manage.js.
  • A translation-sync sync --fetch --dry-run, run on a local copy with this PR and the 4.x PR merged and the catalog on translations, reports:
3.x: up to date
4.x: up to date

Adds the en source file, which the translation sync needs, moves strings that
Craft 5 already translates to the app category, fixes two untranslatable
strings, and replaces Crowdin with the translation-sync workflow.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4
Co-authored-by: Amp <amp@ampcode.com>
brandonkelly and others added 2 commits November 21, 2026 12:47
- Revision: th ฉบับแก้ไข, pl Wersja, ar النسخة المحفوظة, fa نگارش, is vistuð útgáfa,
  he גרסה שמורה, hu revízió
- ar Class: الصنف (الفئة is Category)
- he Draft: טיוטה
- tr: straight apostrophes, matching tr app.php
- fr: non-breaking spaces before ? : » and after «
@brandonkelly
brandonkelly merged commit 9274be5 into 3.x Nov 21, 2026
8 checks passed
@brandonkelly
brandonkelly deleted the feature/translations-3.x branch November 21, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant