Repository navigation
[4.x] Add translations for every language Craft ships - #109
Merged
Merged
Conversation
Adds the en source file, which the translation sync needs, and moves strings that Craft 6 already translates to the app category. Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4 Co-authored-by: Amp <amp@ampcode.com>
…and tr Craft’s app.php uses these languages’ words for an email subject (الموضوع, موضوع, נושא, Subjek, Konu), so “Subject Class” read as an email subject class.
- Revision: th ฉบับแก้ไข, pl Wersja, ar النسخة المحفوظة, fa نگارش, is vistuð útgáfa, he גרסה שמורה, hu revízió - ar Class: الصنف (الفئة is Category) - he Draft: טיוטה - tr: straight apostrophes, matching tr app.php - fr: non-breaking spaces before ? : » and after «
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensource file. Without the source file, the translation sync has nothing to read.lang/en/webhooks.php(76 strings) and full translations for all 33 languages Craft ships. The existing Chinese translation is now complete, and its Crowdin-era errors are fixed.app.php. Labels were checked against the code where their meaning was ambiguous.app.php(such as “Name”, “Status”, “Yes”/“No”/“Any”, and “Delete”) now uset()'s defaultappcategory. Everything else useswebhooks.t(ucfirst($status)), so no extractor could see its strings. It now callst('Pending')andt('Requested', category: 'webhooks')explicitly./crowdin.ymlline from.gitattributes. The sync workflow lives on3.x, the default branch.enaslinguist-generated=truein.gitattributes(/lang/*/webhooks.php, withenexempted), so diffs collapse them and language stats ignore them.## Unreleased.Important
Merge this PR before #110. See that PR for why.
Evidence
cms's
.agents/skills/translations/scripts/check.php(withapp.phpswapped forwebhooks.php):pint --testpasses,pestpasses (31 tests), andphpstanreports no errors.app), “Erneut senden”, “Anfrage”, “Versuche”, “Aktivität”, and “Antwort”.translation-sync sync --fetch --dry-run, run on a local copy with this PR and the3.xPR merged, reports3.x: up to dateand4.x: up to date.