Skip to content

[4.x] Add translations for every language Craft ships - #109

Merged
brandonkelly merged 4 commits into
4.xfrom
feature/translations-4.x
Nov 21, 2026
Merged

brandonkelly merged 4 commits into
4.xfrom
feature/translations-4.x

Conversation

@brandonkelly

@brandonkelly brandonkelly commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Webhooks had only a partial Chinese translation and no en source file. Without the source file, the translation sync has nothing to read.
  • This adds lang/en/webhooks.php (76 strings) and full translations for all 33 languages Craft ships. The existing Chinese translation is now complete, and its Crowdin-era errors are fixed.
    • Terms, register, and quote style follow each language's Craft 6 app.php. Labels were checked against the code where their meaning was ambiguous.
  • Translation category audit:
    • Strings that exist verbatim in Craft 6's app.php (such as “Name”, “Status”, “Yes”/“No”/“Any”, and “Delete”) now use t()'s default app category. Everything else uses webhooks.
    • The Activity page's status label used t(ucfirst($status)), so no extractor could see its strings. It now calls t('Pending') and t('Requested', category: 'webhooks') explicitly.
  • Drops the /crowdin.yml line from .gitattributes. The sync workflow lives on 3.x, the default branch.
  • Marks every translation file except en as linguist-generated=true in .gitattributes (/lang/*/webhooks.php, with en exempted), so diffs collapse them and language stats ignore them.
  • “Subject Class” and the subject attributes string use each language’s word for “object” in ar, fa, he, id, and tr, because their word for “subject” is Craft’s email subject there.
  • Adds release notes under ## Unreleased.

Important

Merge this PR before #110. See that PR for why.

Evidence

cms's .agents/skills/translations/scripts/check.php (with app.php swapped for webhooks.php):

each of 33 languages: 76 of 76 translated   (exit 0)
  • pint --test passes, pest passes (31 tests), and phpstan reports no errors.
  • A scratch Pest test rendered the Activity pages for a German-language user. They showed “Anstehend” (Pending, from Craft's app), “Erneut senden”, “Anfrage”, “Versuche”, “Aktivität”, and “Antwort”.
  • A translation-sync sync --fetch --dry-run, run on a local copy with this PR and the 3.x PR merged, reports 3.x: up to date and 4.x: up to date.

Adds the en source file, which the translation sync needs, and moves strings
that Craft 6 already translates to the app category.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1fd86-ffb2-76c4-b569-c32882de64d4
Co-authored-by: Amp <amp@ampcode.com>
brandonkelly and others added 3 commits November 21, 2026 12:47
…and tr

Craft’s app.php uses these languages’ words for an email subject (الموضوع,
موضوع, נושא, Subjek, Konu), so “Subject Class” read as an email subject class.
- Revision: th ฉบับแก้ไข, pl Wersja, ar النسخة المحفوظة, fa نگارش, is vistuð útgáfa,
  he גרסה שמורה, hu revízió
- ar Class: الصنف (الفئة is Category)
- he Draft: טיוטה
- tr: straight apostrophes, matching tr app.php
- fr: non-breaking spaces before ? : » and after «
@brandonkelly
brandonkelly merged commit 29bb508 into 4.x Nov 21, 2026
7 checks passed
@brandonkelly
brandonkelly deleted the feature/translations-4.x branch November 21, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant