Skip to content

Provide a BOM that manages only the Wicket modules - #1895

Merged
dashorst merged 2 commits into
apache:masterfrom
reckart:Provide-a-BOM-that-manages-only-the-Wicket-modules-1894
Nov 15, 2026
Merged

dashorst merged 2 commits into
apache:masterfrom
reckart:Provide-a-BOM-that-manages-only-the-Wicket-modules-1894

Conversation

@reckart

@reckart reckart commented Nov 13, 2026

Copy link
Copy Markdown
Member

GitHub issue #1894

  • Wicket published no BOM; importing wicket-parent with scope import pulled in the whole build's dependency management (third-party versions and scopes), overriding other BOMs depending on import order and triggering Maven 4 warnings about conflicting management
  • Add a wicket-bom module whose published POM is generated by the bom-builder3 plugin from the reactor: no parent, only the published Wicket modules at the project version, no scopes
  • Exclude parent/aggregator POMs, the archetype, the examples war and the unpublished test, benchmark, coverage and user guide modules
  • Applications can import org.apache.wicket:wicket-bom instead of wicket-parent; importing wicket-parent keeps working as before

Assisted-by: Anthropic Claude (claude-opus-5-5)

GitHub issue apache#1894

- Wicket published no BOM; importing wicket-parent with scope import pulled in the whole build's dependency management (third-party versions and scopes), overriding other BOMs depending on import order and triggering Maven 4 warnings about conflicting management
- Add a wicket-bom module whose published POM is generated by the bom-builder3 plugin from the reactor: no parent, only the published Wicket modules at the project version, no scopes
- Exclude parent/aggregator POMs, the archetype, the examples war and the unpublished test, benchmark, coverage and user guide modules
- Applications can import org.apache.wicket:wicket-bom instead of wicket-parent; importing wicket-parent keeps working as before

Assisted-by: Anthropic Claude (claude-opus-5-5)
@reckart reckart self-assigned this Nov 13, 2026
@reckart

reckart commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

If we merge this, we should also backport it to other maintained versions.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.80%. Comparing base (745ae01) to head (8384e37).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1895      +/-   ##
============================================
- Coverage     62.82%   62.80%   -0.03%     
+ Complexity    11550    11549       -1     
============================================
  Files          1254     1254              
  Lines         48726    48726              
  Branches       6867     6867              
============================================
- Hits          30614    30604      -10     
- Misses        15420    15431      +11     
+ Partials       2692     2691       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashorst dashorst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

@dashorst
dashorst merged commit 5c4ed11 into apache:master Nov 15, 2026
0 of 3 checks passed
@dashorst

Copy link
Copy Markdown
Contributor

Thanks Richard, merged. I tested it locally: the generated BOM manages exactly the published modules, a consumer importing it resolves Wicket artifacts without versions and gets no third-party management, and a partial -pl build still produces the full BOM. master had moved on, so I merged it into your branch first (a one-line conflict next to the build-helper version bump). Documenting the BOM is tracked in #1925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants