Repository navigation
Provide a BOM that manages only the Wicket modules (10.x) - #1930
Merged
Merged
Conversation
GitHub issue #1894 GitHub issue #1926 - Wicket published no BOM; importing wicket-parent with scope import pulled in the whole build's dependency management (third-party versions and scopes), overriding other BOMs depending on import order and triggering Maven 4 warnings about conflicting management - Add a wicket-bom module whose published POM is generated by the bom-builder3 plugin from the reactor: no parent, only the published Wicket modules at the project version, no scopes - Exclude parent/aggregator POMs, the archetype, the examples war and the unpublished test and user guide modules - Applications can import org.apache.wicket:wicket-bom instead of wicket-parent; importing wicket-parent keeps working as before Assisted-by: Anthropic Claude (claude-opus-5-5) (cherry picked from commit 8384e37) Backport to wicket-10.x: parent version 10.13.0-SNAPSHOT, experimental groupId org.apache.wicket.experimental.wicket10, and no exclusions for wicket-benchmarks and wicket-coverage, which are not in the 10.x reactor. The plugin property conflict was resolved by keeping 10.x's build-helper-maven-plugin 3.8.0. Generated-by: Claude Code (Claude Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1926. Backport of #1895 (Richard's commit 8384e37, cherry-picked with
-x, author kept) to wicket-10.x: addsorg.apache.wicket:wicket-bom, whose published POM is generated by bom-builder3 1.3.4 from the reactor and manages only the published Wicket modules, without a parent or scopes.Adapted for 10.x in
wicket-bom/pom.xml: parent version 10.13.0-SNAPSHOT, experimental groupIdorg.apache.wicket.experimental.wicket10, and no exclusions for wicket-benchmarks and wicket-coverage, which the 10.x reactor doesn't have. The exclusion list matches the modules that skip deploy on 10.x: wicket-core-tests, wicket-cdi-tests, wicket-common-tests, wicket-js-tests and wicket-user-guide. The only conflict was in the plugin version properties in the root pom; 10.x's build-helper-maven-plugin 3.8.0 is kept.The generated BOM lists 22 artifacts at 10.13.0-SNAPSHOT: wicket (pom), wicket-auth-roles, wicket-bean-validation, wicket-cdi, wicket-core, wicket-devutils, wicket-extensions, wicket-extensions-tester, wicket-guice, wicket-ioc, wicket-jmx, wicket-migration, wicket-native-websocket-core, wicket-native-websocket-javax, wicket-native-websocket-tester, wicket-objectsizeof-agent, wicket-request, wicket-spring, wicket-tester, wicket-util, wicket-velocity, and
org.apache.wicket.experimental.wicket10:wicket-metrics.Tested with
mvn clean verify -Pjs-test(Maven 3.9.16, Java 21): all modules pass; japicmp skips wicket-bom because its packaging is pom. A consumer project that imports the BOM with<scope>import</scope>resolveswicket-corewithout a version.Documentation in the migration guide is tracked in #1925.
🤖 Generated with Claude Code