Skip to content

Chat refresh 1/5: radius scale, tints and in-app confirm dialog - #527

Draft
BunsDev wants to merge 3 commits into
mainfrom
chat-refresh-foundation
Draft

BunsDev wants to merge 3 commits into
mainfrom
chat-refresh-foundation

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First of five PRs for the chat and prompts refresh. Val approved the design on 2026-11-15: docs/superpowers/specs/2026-11-15-chat-prompts-refresh-design.md. This PR is the foundation the other four build on; its plan is docs/superpowers/plans/2026-11-15-chat-refresh-foundation.md.

What changes

One radius scale for every button and component. Surfaces are 8 px, controls 6 px, and parts inside a control 4 px. The tokens change in tokens.css, and the 285 radius declarations that were written as numbers in the desktop renderer, the Store edition and the web demo move onto them (apps/site is untouched). Only status dots, progress dots and spinners stay round, so the send button and the other round buttons become rounded squares. scripts/test/radius-scale.test.mjs fails on a hard-coded radius above 2 px and pins how many circles each stylesheet has.

Three derived tokens in the base :root only: --tint, --tint-strong, --hairline. No theme block changes.

One in-app confirm dialog replaces all ten window.confirm calls: YOLO (composer and approval card), cloud model, delete thread with worktree, remove project, discard changes, reset learning, remove local connection, delete task (row menu and page). confirmDialog(options) returns a promise; one ConfirmHost in App renders the current request. Cancel has focus when it opens, the action button names the action, Escape and the backdrop cancel, Tab stays inside, and nothing behind the dialog reacts to a key. Each existing sentence keeps all of its facts, split across title, body, path and a kept/lost list.

What was and was not run

This was written in a session that could not install dependencies, so CI is the first full run.

  • Run and passing: scripts/test/radius-scale.test.mjs (4 tests); the confirm store's unit test, type-stripped (4 tests); the rest of scripts/test (232 of 234 pass, 1 skipped; the 1 failure, cf8-retention "real Playwright worker", needs the npm registry and fails the same way on unchanged main there).
  • Checked without running: every changed TypeScript file parses; the new dialog, store and unit test type-check against stand-in React and Node declarations; a script confirmed the stylesheet sweep changed radius values and nothing else.
  • Not run: pnpm build, pnpm test, pnpm test:e2e. The Electron specs changed here have never executed.

Review notes

  • layout.spec.ts radius assertions move to the new scale (sheet 8, row 6, composer 8, send 6, bubble 8).
  • Eight specs that answered a native dialog now call answerConfirm(page, "accept" | "cancel", text?) after the click that asks. approval-policy.spec.ts no longer stubs window.confirm.
  • New confirm-dialog.spec.ts: focus on Cancel, Tab cycle, Escape, backdrop, a shortcut pressed behind the dialog, and a confirm opened over Settings.
  • After accepting "Reset learning", focus no longer stays on the button that asked, because that button is disabled while the reset runs.
  • Commits are signed with this session's key. If GitHub does not show them as verified, the squash merge still produces a signed commit on main.

Next

Menus, transcript rows, the request panel and the composer follow as PRs 2 to 5, each with its own plan from the same design.

https://claude.ai/code/session_011Ya6qvLmxrim1dK1KjEpJ7


Generated by Claude Code

Surfaces are 8 px, controls 6 px and parts inside a control 4 px. Every
hard-coded radius in the desktop renderer, the Store edition and the web
demo moves onto the tokens; only dots and spinners stay round. Adds
--tint, --tint-strong and --hairline to the base tokens, and a test that
fails on a hard-coded radius.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Ya6qvLmxrim1dK1KjEpJ7
confirmDialog(options) resolves true on accept and false on cancel.
Requests are answered one at a time, oldest first.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Ya6qvLmxrim1dK1KjEpJ7
One ConfirmHost, mounted in App, answers every confirmation: YOLO, cloud
model, delete thread, remove project, discard changes, reset learning,
remove local connection and delete task. Cancel has focus when it opens,
the action button names the action, Escape and the backdrop cancel, and
nothing behind the dialog reacts to the keyboard. Each existing sentence
keeps all of its facts.

The specs that answered a native dialog now answer the in-app one through
answerConfirm; a new spec covers focus, Escape, shortcuts and a confirm
opened over Settings. Adds the approved design, this PR's plan and the
status entry.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Ya6qvLmxrim1dK1KjEpJ7
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 16, 2026 4:33am UTC
modex-app Ready Ready Preview Nov 16, 2026 4:33am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 538d357 chat-refresh-foundat... c093a0b +/-
66% 66% 0%
View coverage of the 3 most impacted files.
File main 538d357 chat-refresh-foundat... c093a0b +/-
apps/desktop/sr...nts/ui/Icon.tsx 99% 99% 0%
apps/desktop/sr...nfirmDialog.tsx 0% 0% 0%
apps/desktop/sr...erer/confirm.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch was successfully deployed

1 active deployment
Preview – modex — c093a0b9 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants