Skip to content

Chat refresh 2/5: one-line menus with a description at the foot - #528

Draft
BunsDev wants to merge 1 commit into
chat-refresh-foundationfrom
chat-refresh-menus
Draft

BunsDev wants to merge 1 commit into
chat-refresh-foundationfrom
chat-refresh-menus

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Second of five PRs for the chat and prompts refresh, stacked on #527 (its base is chat-refresh-foundation, so this diff shows only the menu work). Design: docs/superpowers/specs/2026-11-15-chat-prompts-refresh-design.md, section "2. Menus". Plan: docs/superpowers/plans/2026-11-16-chat-refresh-menus.md.

What changes

Menu and MenuItem take an optional hint.

  • A row with a hint stays on one line (32 px). The sentence that sat under its title becomes the row's aria-description.
  • A menu with a hint is 264 px wide and shows one description at its foot, for the row under the pointer or the keyboard focus. The foot is aria-hidden, so the sentence is not read twice.
  • An on/off row with a hint shows a switch instead of a check; its state is still the row's aria-checked.

The composer's two menus use it. The access menu (modes, and approvals on a thread) gains an "Access" label and opens with the current mode focused. The + menu shows Plan and Auto as switches. Every description is today's sentence, word for word; "Add files or images to your next message." is new, for Attach files, which had none. A backend's description moves from its title tooltip to the foot.

Every menu takes the refreshed shell: hairline border, elevated surface, a short opacity fade on open, tinted hover and selection. Menus that pass no hint (the model picker and the others) keep their rows and content.

What was and was not run

Written in a session that cannot install dependencies, like #527, which then passed CI on its first run.

  • Run and passing: scripts/test/radius-scale.test.mjs.
  • Checked without running: the changed files parse; Menu.tsx type-checks against stand-in React declarations.
  • Not run: pnpm build, pnpm test, pnpm test:e2e. CI is the first full run, and e2e/menu-hints.spec.ts has never executed.

Review notes

  • No existing test id, role or accessible name changes. "Attach files" is still the first row's exact name and the checked backend still reads "Mock".
  • A disabled row may not report the pointer in Chromium, so its description might not reach the foot on hover; it is always on the row itself. In the + menu every row is disabled while a turn runs.
  • Selection in menus without hints now uses --tint-strong on the elevated surface instead of the row-selected colour on the sidebar colour.
  • PR 5 moves access to tabs and approvals to their own menu; the hints stay with their rows.

Generated by Claude Code

Menu and MenuItem take an optional hint. A row with a hint stays on one
line and carries the sentence as its aria-description; a menu with a hint
shows one description at its foot for the row under the pointer or the
focus. The composer's access and + menus use it, with Plan and Auto as
switches. Every sentence is the existing copy, plus one new line for
Attach files.

All menus take the refreshed shell: hairline border, elevated surface,
tinted hover and selection. Menus that pass no hint keep their rows.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Ya6qvLmxrim1dK1KjEpJ7
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 16, 2026 6:37am UTC
modex-app Building Building Preview Nov 16, 2026 6:37am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

chat-refresh-foundat... 538d357 chat-refresh-menus e4db82a +/-
66% 66% 0%
View coverage of the 4 most impacted files.
File chat-refresh-foundat... 538d357 chat-refresh-menus e4db82a +/-
apps/desktop/sr...nts/ui/Menu.tsx 36% 36% 0%
apps/desktop/sr...nts/ui/Icon.tsx 99% 99% 0%
apps/desktop/sr...nfirmDialog.tsx 0% 0% 0%
apps/desktop/sr...erer/confirm.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch was successfully deployed

1 active deployment
Preview – modex — e4db82ad Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants