Skip to content

qt sidebar: apply shared scheme styles to bars and panes - #1974

Merged
trissim merged 1 commit into
mainfrom
fork-bar-theming
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
fork-bar-theming

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown

Qt sidebar panes and toggle bars applied no background stylesheet and inherited the parent QWidget's default colour, so the themed sidebar tone never reached the sidebar.

Applied pyqt-reactive's new generate_sidebar_pane_style() / generate_sidebar_bar_style() (keyed on #SidebarPane / #SidebarToggle object-names set by formbridge) after construction, mirroring the pattern already used for float layer / tabs / chrome.

  • Pane paints SidebarToneColour (matches Textual's SideBar.tone)
  • Bar paints HeaderToneColour (matches Textual's toggle-bar CSS)

Pairs with pyqt-reactive OpenHCSDev/PyQT-reactive#62 + formbridge OpenHCSDev/formbridge#39.

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

Qt sidebar panes and toggle bars applied no background stylesheet and inherited
the parent QWidget's default colour, so the themed sidebar tone never reached
the sidebar. Pull from pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` (keyed on `#SidebarPane` / `#SidebarToggle`
object-names set by formbridge) and apply each after construction, mirroring
the pattern already used for float layer, tab widget and bottom chrome.

Pane paints `panel_bg` (SidebarToneColour — Textual's `SideBar.tone`).
Bar paints `frame_bg` (HeaderToneColour — Textual's toggle-bar CSS at
`widgets/side_bar.py:322` tinting PrimaryColour at 8%).

Pairs with:
- pyqt-reactive OpenHCSDev/PyQT-reactive#62
- formbridge OpenHCSDev/formbridge#39

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit bc7d60c into main Nov 17, 2026
1 check failed
trissim added a commit that referenced this pull request Nov 17, 2026
`Sidebar.filter` + `_on_filter_changed` and `draw_lines` filtering already
landed through PR #1974's co-paint of nearby chunks, but the `QLineEdit` that
writes the shared owner's text was still missing, so the match machinery had
no way to receive a user keystroke.

`QtSidebarSearch` stacks a `QLineEdit` over the `Sidebar` tree. The sidebar
pane takes the wrapper as its content so the input is visible at the top of
the pane, mirroring Textual's `SideBar._compose_shell` which stacks
`SidebarSearch` over its panels for the same reason. The input writes directly
through `sidebar.filter.text`; the tree's existing subscriber re-presents so
every channel/thread row re-asks `SidebarFilter.matches(name)` on each keystroke.


Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant