Repository navigation
Qt sidebar: expose the search input via QtSidebarSearch - #1975
Merged
Merged
Conversation
`Sidebar.filter` + `_on_filter_changed` and `draw_lines` filtering already landed through PR #1974's co-paint of nearby chunks, but the `QLineEdit` that writes the shared owner's text was still missing, so the match machinery had no way to receive a user keystroke. `QtSidebarSearch` stacks a `QLineEdit` over the `Sidebar` tree. The sidebar pane takes the wrapper as its content so the input is visible at the top of the pane, mirroring Textual's `SideBar._compose_shell` which stacks `SidebarSearch` over its panels for the same reason. The input writes directly through `sidebar.filter.text`; the tree's existing subscriber re-presents so every channel/thread row re-asks `SidebarFilter.matches(name)` on each keystroke. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar.filter+_on_filter_changedanddraw_linesfiltering were co-landed via PR #1974, but theQLineEditthat writes the shared owner's text was still missing — so the match machinery had no way to receive a user keystroke.QtSidebarSearchstacks aQLineEditover theSidebartree. The sidebar pane takes the wrapper as its content so the input is visible at the top of the pane, mirroring Textual'sSideBar._compose_shellwhich stacksSidebarSearchover its panels for the same reason. The input writes directly throughsidebar.filter.text; the tree's existing subscriber re-presents so every channel/thread row re-asksSidebarFilter.matches(name)on each keystroke.🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn