Repository navigation
Share human-read evidence across notification presentation passes - #4904
Merged
Merged
Conversation
|
debt-src at c80b30b blocks on 2 lines: Warn-only, never blocks (2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One human-read capture for the whole notification presentation pass
The original real three-thread presentation control acquired ReadLedger three times; it now requires one. This removes repeated whole-document detachment per window, rather than weakening the store's detached-read contract. The initial witness failed as expected. Final critical rerun: 50 passed, exit 0. Earlier affected-family runs reached 53, 85 and 244 passing controls respectively; their exposed stale controls were corrected and are included in the final rerun. These overlapping groups are not added together. No overall CPU or stable wall-clock saving is claimed.
HumanReadCut owns the root and its first ledger/document read for one short-lived pass. NotificationSource composes that scope with AssignmentSource through native multiple inheritance. Assignment-only consumers remain independent. ThreadPresentations shares the composed source across its existing open readings scope; live and recorded reference readers hold one cut across every bounded chunk. Every projector takes its root, ledger and document from that cut.
CapturedNotificationEvidence implements the same role with its original explicit fields; constructor field names/order remain root, ledger, document, snapshot. No stored or wire record shape changes. Human display, model consumption, independent replies and assignment state remain distinct. Original recipient births, visibility, bus identities and direct-human read projection retain their existing owners.
History's lower reader contract
HistoryReadSource composes the existing RelationshipSource and InputIngressContext contracts, with no copied fields or forwarding methods. HistoryViews inherits it. The historical reader annotates that actual lower contract instead of hiding an import of the whole facade. NRA's promote_guarded_import passed against the complete src/tests/tools import graph. Runtime type-hint resolution and MRO/constructor checks passed.
Verification
P283. Part of the continuing solo CPU-factoring goal; backend-free activity-client startup and other measured paths remain open.
Installed result and fixture correction
Installed8055175b,exit0;15 installed controls passed and fresh request23608 was answered23610. The later wider observer follow-up reached53passes then timed out; it was not green. Test-only follow-up4905 merged4beef903 restores the shared single-pass fixture and drains the notification fixture after reading its frames;15 focused observer controls then passed. No second install was needed for that test-only change. P283 delivery is recorded in Core. No overall CPU or old-window saving claim.