Skip to content

Drain notification replies before settling their test read - #4905

Merged
trissim merged 1 commit into
mainfrom
fix/notification-test-settlement
Nov 18, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/notification-test-settlement

Conversation

@trissim

@trissim trissim commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

15 focused observer controls passed, exit 0

Follow-up to #4904: the shared watched_pass fixture must remain one service pass, because its callers consume pipe frames between passes. Draining every scheduled step there could fill the pipe before its caller read it. The post-merge four-file run exposed this: 53 controls passed, then the run timed out; that receipt is retained, not claimed green.

Restore the shared fixture's original single-pass contract. The notification fixture now drains its two frames first, then finishes that answered notification's remaining generator steps. The next source mutation therefore reaches a fresh revision without changing other observer fixtures' lifetime.

15 focused controls passed, including input-only consumption, reply-only evidence, actual team-page preparation, encoded replies, settings context and observer fairness. No product behavior changes, no new environment/model/agent/window or input replay. #4904's production scoped human-read owner remains installed as 8055175; this is a test correction, not an overall CPU claim.

P283; continuing solo CPU-factoring goal. Original failure and corrected run are retained in notification-read-cut scratch.

@trissim
trissim marked this pull request as ready for review November 18, 2026 23:16
@trissim
trissim merged commit 4beef90 into main Nov 18, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant