Repository navigation
Drain notification replies before settling their test read - #4905
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
November 18, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15 focused observer controls passed, exit 0
Follow-up to #4904: the shared watched_pass fixture must remain one service pass, because its callers consume pipe frames between passes. Draining every scheduled step there could fill the pipe before its caller read it. The post-merge four-file run exposed this: 53 controls passed, then the run timed out; that receipt is retained, not claimed green.
Restore the shared fixture's original single-pass contract. The notification fixture now drains its two frames first, then finishes that answered notification's remaining generator steps. The next source mutation therefore reaches a fresh revision without changing other observer fixtures' lifetime.
15 focused controls passed, including input-only consumption, reply-only evidence, actual team-page preparation, encoded replies, settings context and observer fairness. No product behavior changes, no new environment/model/agent/window or input replay. #4904's production scoped human-read owner remains installed as 8055175; this is a test correction, not an overall CPU claim.
P283; continuing solo CPU-factoring goal. Original failure and corrected run are retained in notification-read-cut scratch.