Skip to content

style_generator: add sidebar pane + toggle-bar styles - #62

Merged
trissim merged 1 commit into
mainfrom
fix/sidebar-bar-pane-style
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/sidebar-bar-pane-style

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Qt sidebar bar widgets (SidebarPane, SidebarToggle) previously applied no background stylesheet and leaked their parent QWidget's colour instead of painting the scheme's sidebar tone. Added two generators:

  • generate_sidebar_pane_style() → reads panel_bg (SidebarToneColour), mirrors Textual's SideBar.tone = SidebarToneColour
  • generate_sidebar_bar_style() → reads frame_bg (HeaderToneColour), mirrors Textual's toggle-bar CSS at widgets/side_bar.py:322

Both key on #SidebarPane / #SidebarToggle object-names so children of other widgets aren't affected.

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

Qt's SidebarPane and SidebarToggle (formbridge widgets) previously applied no
background stylesheet, so they leaked their parent QWidget's colour instead of
painting the scheme's sidebar tone — the bars looked wrong against the themed
window because they inherited the default system palette for their fill.

Added `generate_sidebar_pane_style()` (reads `panel_bg` →
`SidebarToneColour`, mirroring Textual's `SideBar.tone = SidebarToneColour`)
and `generate_sidebar_bar_style()` (reads `frame_bg` → `HeaderToneColour`,
the same header-strip tone Textual's toggle bar CSS at `widgets/side_bar.py:322`
sets via `PrimaryColour × 8%`). Both key on `#SidebarPane` / `#SidebarToggle`
object-names so the style doesn't leak into unrelated children.

Toad calls these in the same shape it already uses `generate_frame_style` and
`generate_tab_widget_style` on the float layer and tab widget.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit 96cce1b into main Nov 17, 2026
3 of 12 checks passed
trissim added a commit to OpenHCSDev/toad that referenced this pull request Nov 17, 2026
Qt sidebar panes and toggle bars applied no background stylesheet and inherited
the parent QWidget's default colour, so the themed sidebar tone never reached
the sidebar. Pull from pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` (keyed on `#SidebarPane` / `#SidebarToggle`
object-names set by formbridge) and apply each after construction, mirroring
the pattern already used for float layer, tab widget and bottom chrome.

Pane paints `panel_bg` (SidebarToneColour — Textual's `SideBar.tone`).
Bar paints `frame_bg` (HeaderToneColour — Textual's toggle-bar CSS at
`widgets/side_bar.py:322` tinting PrimaryColour at 8%).

Pairs with:
- pyqt-reactive OpenHCSDev/PyQT-reactive#62
- formbridge OpenHCSDev/formbridge#39

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
trissim added a commit to OpenHCSDev/toad that referenced this pull request Nov 17, 2026
Qt sidebar panes and toggle bars applied no background stylesheet and inherited
the parent QWidget's default colour, so the themed sidebar tone never reached
the sidebar. Pull from pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` (keyed on `#SidebarPane` / `#SidebarToggle`
object-names set by formbridge) and apply each after construction, mirroring
the pattern already used for float layer, tab widget and bottom chrome.

Pane paints `panel_bg` (SidebarToneColour — Textual's `SideBar.tone`).
Bar paints `frame_bg` (HeaderToneColour — Textual's toggle-bar CSS at
`widgets/side_bar.py:322` tinting PrimaryColour at 8%).

Pairs with:
- pyqt-reactive OpenHCSDev/PyQT-reactive#62
- formbridge OpenHCSDev/formbridge#39


Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant