Repository navigation
Input behaviour (#66, Part 2) - #70
Merged
Merged
Conversation
…uttons (#66, 2.1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#66, 2.4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 2.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 2.6) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…66, 2.7) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, 2.8) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 2.9) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…2-inputs # Conflicts: # packages/onu/src/components/date/hijri-date-picker.tsx
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Part 2 of #66 (input behaviour, items 2.1–2.10). One commit per item, each with a test that failed first.
NumberInputminonly on blur. Arrow keys and the − / + buttons now share one stepping function (toFixed(10)against float drift), so 10.5 + ArrowUp is 11.5, not 12.SlugInputseparator.toSlug(…, { preserveTrailing })now works for every separator, not only-.TagsInputuseComboboxStategained anisDisabled(index)option; TagsInput passes it.Autocompletevalueset from outside, so resetting to""shows the full list.InlineEditvalidate(or async save error) on blur shows the error without pulling focus back. Enter / Escape / the buttons still return or keep focus as before.ReportingPeriodPickercommit()clears the pending custom range, so an abandoned custom click no longer overwrites a monthly/quarterly/yearly pick on close.DateCalendarcanPrev/canNext.PeriodGridgainedcanPrev/canNextprops (defaulttrue);handleGridKeygainedcanPage. The day view already stopped atmin/max(checked).HijriDatePickerinMonthcompares against the next month's midnight, so a value ortodaywith a time on the last day of the month opens focused on that day, not the 1st.WizardonCompletesettles (plus a ref guard against same-tick re-entry), so Finish can't runonCompletetwice.SearchBox"") instead of the blur search followed by"".Skipped ([P] / device check)
\donly matches ASCII digits for a customnumberLocale.Could not reproduce
Behaviour/API changes worth noting
toSlug("trailing ", { preserveTrailing: true })now returns"trailing-"(it was"trailing"); the old test assertion pinned the bug and was updated.useComboboxState(count, { isDisabled })(internal) andPeriodGridcanPrev/canNext(internal) are new options.Wizard: the Finish button stays disabled with a spinner whileonCompleteruns.InlineEdit: an async save that fails after a blur no longer refocuses the field (same rule as thevalidatecase).Verification
pnpm lint,pnpm format:check,pnpm typecheck: passpnpm --filter @javaabu/onu exec vitest run --maxWorkers=3: 197 files, 2872 passed, 1 skippednode scripts/check-docs.mjs: Docs OKpnpm buildandpnpm --filter @javaabu/onu size: pass, no budgets changed🤖 Generated with Claude Code