Repository navigation
Charts, maps, media and export (#66, Part 8) - #76
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 8.3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#66, 8.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure feedback (#66, 8.7) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d decoder (#66, 8.8) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…de in the provider region (#66, 8.9) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#66, 8.13) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…8-media-export # Conflicts: # packages/onu/src/components/layout/wizard.tsx
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Part 8 of #66 (charts, maps, media and export). One commit per item, each with a test that failed first, a changeset, and docs updates where behaviour or API changed.
date/datetimecells are written as the local wall-clock time (moved into UTC, which is howwrite-excel-fileserialises), so they match CSV and PDF. Reproduced withTZ=Indian/Maldives.toDaterejectsNaN,Infinityand out-of-range timestamps; such cells are empty. PDF no longer throws aRangeError, CSV no longer writesNaN-NaN-NaN.TimeSeriesChartintervalnow buckets rows: each row goes to the start of its hour/day/week/month, rows in one step are added up (newaggregate="mean"averages them), weeks count from the first date so off-grid rows are kept, and a range of more than 10,000 steps keeps all rows (without gap rows) instead of cutting off the newest.normalizeTimeSeriestakesaggregateas a 4th argument.MediaPlayerkeys the<video>/<audio>element by its source list, so a newsrcloads.SignaturePad:penColornow defaults to#000and is the ink both on screen and in the export; in dark mode the canvas is shown withdark:invert dark:hue-rotate-180, and the border/background moved to the wrapper so they aren't inverted. A saveddefaultValueimage is redrawn after a resize (strokes on top).cropImagefills JPEG output white before drawing, so transparent areas aren't black.AvatarUploadnames the file after the output type (me.pngwithcropOptions={{ type: "image/png" }}).QrCode: with no background of its own (tone="transparent"), a light foreground is saved as#000000on white. The SVG download fetches the logo and embeds it as a data URL, and leaves it out when it can't be fetched. A failed download shows "Could not download the QR code" as an alert (newfile.qrDownloadFailed, en + dv).QrCodeScannercontinuous: a code that stays in view is reported once and counts again after a second out of view. If the detector fails to load, the newdecoder-errorstatus keeps the Start button so the user can retry (newinput.scanDecoderError, en + dv).Drawmerges the terra-draw snapshot with the current value, so a shape with too few points to draw (being typed in) survives map edits.LiveMap: when a marker changes inmarkers(position, heading orupdatedAt) or leaves it, its earlier streamed update is dropped, andsubscribe(push, remove)gets aremove(id)callback. Geocoding uses theMapProviderregion(added to the map context).MapChartstores the selected region's id and reads the region from the current data, so the read-out followsdata/geojsonchanges and clears when the region goes.ImageCroppertakes up a changedaspectprop.Wizardcatches a rejectedvalidate/onValidateStep/onCompleteand marks the step as having errors.LoadMorecatches a rejectedonLoadMore, shows "Couldn’t load more. Try again." and keeps the button. The comment composer keeps the text and shows "Couldn’t save. Try again." New stringslisting.loadMoreFailedanddisplay.composerFailed, en + dv.Skipped ([P] / device check)
MapRadiusdouble report.TimeSeriesChartzoom range.Could not reproduce
Behaviour/API changes worth noting
SignaturePadpenColordefaults to"#000"(was the theme text colour). In dark mode the canvas is shown inverted.classNames.canvasno longer carries the border/background, which are now on the wrapper.TimeSeriesCharthas a newaggregate?: "sum" | "mean". Withinterval, each point's__timeis now the start of its step (it used to be the row's own time).LiveMapSubscribeis now(push, remove) => unsubscribe.ScannerStatusadds"decoder-error". A detector that fails to load no longer gives"unsupported".MapContextValueaddsregion.file.qrDownloadFailed,input.scanDecoderError,listing.loadMoreFailed,display.composerFailed.Overlaps with other open parts
media/signature-pad.tsx(Part 4, Effects keyed on unstable identities (#66, Part 4) #69, holdstin a ref): this PR edits the pad-creation effect (penColorinstead ofink()) and the resize function, near the lines Effects keyed on unstable identities (#66, Part 4) #69 touches.layout/wizard.tsx(Part 2, Input behaviour (#66, Part 2) #70, rewrotenext()): this PR only adds acatch { ok = false }to the validationtryand a try/catch aroundawait onComplete?.().listing/load-more.tsx(Part 4.4): this PR adds acatchand afailedstate inload().Verification
pnpm lint,pnpm format:check,pnpm typecheck: pass.pnpm --filter @javaabu/onu exec vitest run --maxWorkers=3: 197 files, 2885 passed, 1 skipped.TZ=Indian/Maldivesrun ofsrc/exportandsrc/charts: 223 passed.node scripts/check-docs.mjs: Docs OK.pnpm build && pnpm --filter @javaabu/onu size: build OK, all budgets pass, none raised.🤖 Generated with Claude Code