Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,21 @@
"@types/express": "4.17.21",
"@types/express-serve-static-core": "4.17.43",
"express": "^4.20.0",
"lodash": "4.18.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — The lodash override is an exact version, not a minimum like the other entries

Change it to "lodash": "^4.18.1". The exact 4.18.1 forces every lodash request to that version, including the workspace's own ^4.18.1 requests (yarn.lock ~4819/4938/5042). If a later 4.18.x or 4.19.x security release comes out, or a dependency starts asking for one, Yarn will still install 4.18.1 and yarn up cannot move it.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

"qs": "^6.16.0",
"minimatch@3.1.2": "^3.1.4",
"minimatch@^3.0.4": "^3.1.4",
"minimatch@^3.1.1": "^3.1.4",
"minimatch@^3.1.2": "^3.1.4",
"minimatch@^8.0.2": "^8.0.6",
"minimatch@^9.0.4": "^9.0.7",
"minimatch@^9.0.5": "^9.0.7",
"minimatch@^10.2.2": "^10.2.3",
"picomatch@^4.0.2": "^4.0.4",
"picomatch@^4.0.3": "^4.0.4",
"@hono/node-server": "^1.19.13",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Overrides for @hono/node-server, protobufjs and qs apply to every version range, so a later 2.x/8.x/7.x request would be forced back down

Limit these to the ranges actually requested today, as the minimatch/picomatch lines do: "@hono/node-server@^1.19.9": "^1.19.13", "protobufjs@^7.5.5"/"protobufjs@^7.6.5", and the qs ranges ~6.14.0/^6.11.0/^6.11.2/6.15.1/~6.15.1. As written, "@hono/node-server": "^1.19.13" replaces every request for the package. Today the only request is npm:^1.19.9 from @modelcontextprotocol/sdk (yarn.lock ~6513). When that SDK moves to @hono/node-server@^2, which the PR says is needed for GHSA-rmxm-3fg6-px4f, Yarn will quietly install 1.x instead and the advisory stays unfixed. The blanket protobufjs and qs overrides would do the same to any future 8.x or 7.x request.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

"protobufjs": "^7.6.3",
"smol-toml@1.6.1": "^1.8.0",
"send": "^0.19.0",
"serve-static": "^1.16.0",
"cookie": "^0.7.0",
Expand Down
144 changes: 30 additions & 114 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4712,12 +4712,12 @@ __metadata:
languageName: node
linkType: hard

"@hono/node-server@npm:^1.19.9":
version: 1.19.17
resolution: "@hono/node-server@npm:1.19.17"
"@hono/node-server@npm:^1.19.13":
version: 1.19.18
resolution: "@hono/node-server@npm:1.19.18"
peerDependencies:
hono: ^4
checksum: 10c0/e77907e3b5db8ab68ed4f297ad84807bfdd698636408de86ab8d36dab4658504ac4c0ed9d9436bc272a0172b9b7a5a4b578532e0b5baf97674c7b420cb5cff4b
checksum: 10c0/724fdba976ebe2373937a2e5fe250a8dea1bce7784725352d58c62756b02ad564ce7a7d976a4fae56b367dfefa5cae90d75a7495934c8b0789d71f50aff9ffc3
languageName: node
linkType: hard

Expand Down Expand Up @@ -8753,13 +8753,6 @@ __metadata:
languageName: node
linkType: hard

"@protobufjs/inquire@npm:^1.1.2":
version: 1.1.2
resolution: "@protobufjs/inquire@npm:1.1.2"
checksum: 10c0/af69597818a14cac6a00a74cd5b3fb85aa96658b9dbbae73e6d907cb154ebf470953a8c537b3e6095a43de565ec4e6c5b40227c72f4a7d762d34fbec7ac179e7
languageName: node
linkType: hard

"@protobufjs/path@npm:^1.1.2":
version: 1.1.2
resolution: "@protobufjs/path@npm:1.1.2"
Expand Down Expand Up @@ -13755,7 +13748,7 @@ __metadata:
languageName: node
linkType: hard

"brace-expansion@npm:5.0.8, brace-expansion@npm:^5.0.2, brace-expansion@npm:^5.0.5":
"brace-expansion@npm:5.0.8, brace-expansion@npm:^5.0.5":
version: 5.0.8
resolution: "brace-expansion@npm:5.0.8"
dependencies:
Expand Down Expand Up @@ -13792,7 +13785,7 @@ __metadata:
languageName: node
linkType: hard

"brace-expansion@npm:^5.0.12":
"brace-expansion@npm:^5.0.12, brace-expansion@npm:^5.0.8":
version: 5.0.12
resolution: "brace-expansion@npm:5.0.12"
dependencies:
Expand Down Expand Up @@ -22103,20 +22096,13 @@ __metadata:
languageName: node
linkType: hard

"lodash@npm:^4.17.20, lodash@npm:^4.17.21, lodash@npm:^4.18.1":
"lodash@npm:4.18.1":
version: 4.18.1
resolution: "lodash@npm:4.18.1"
checksum: 10c0/757228fc68805c59789e82185135cf85f05d0b2d3d54631d680ca79ec21944ec8314d4533639a14b8bcfbd97a517e78960933041a5af17ecb693ec6eecb99a27
languageName: node
linkType: hard

"lodash@npm:~4.17.21, lodash@npm:~4.17.23":
version: 4.17.23
resolution: "lodash@npm:4.17.23"
checksum: 10c0/1264a90469f5bb95d4739c43eb6277d15b6d9e186df4ac68c3620443160fc669e2f14c11e7d8b2ccf078b81d06147c01a8ccced9aab9f9f63d50dcf8cace6bf6
languageName: node
linkType: hard

"log-symbols@npm:4.1.0, log-symbols@npm:^4.1.0":
version: 4.1.0
resolution: "log-symbols@npm:4.1.0"
Expand Down Expand Up @@ -23166,16 +23152,7 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:3.1.2, minimatch@npm:^3.0.4, minimatch@npm:^3.1.1, minimatch@npm:^3.1.2":
version: 3.1.2
resolution: "minimatch@npm:3.1.2"
dependencies:
brace-expansion: "npm:^1.1.7"
checksum: 10c0/0262810a8fc2e72cca45d6fd86bd349eee435eb95ac6aa45c9ea2180e7ee875ef44c32b55b5973ceabe95ea12682f6e3725cbb63d7a2d1da3ae1163c8b210311
languageName: node
linkType: hard

"minimatch@npm:3.1.5":
"minimatch@npm:3.1.5, minimatch@npm:^3.1.4":
version: 3.1.5
resolution: "minimatch@npm:3.1.5"
dependencies:
Expand All @@ -23184,12 +23161,12 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:^10.2.2":
version: 10.2.4
resolution: "minimatch@npm:10.2.4"
"minimatch@npm:^10.2.3":
version: 10.2.6
resolution: "minimatch@npm:10.2.6"
dependencies:
brace-expansion: "npm:^5.0.2"
checksum: 10c0/35f3dfb7b99b51efd46afd378486889f590e7efb10e0f6a10ba6800428cf65c9a8dedb74427d0570b318d749b543dc4e85f06d46d2858bc8cac7e1eb49a95945
brace-expansion: "npm:^5.0.8"
checksum: 10c0/4559a836243b98bd4d17ea9f7edae698717c76399eea7be374f3737f33164e4907f19e9726891ddeb122f750a5a7fa80d2ac43e851d6e5984dc4ff42ec127d3a
languageName: node
linkType: hard

Expand All @@ -23203,25 +23180,16 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:^8.0.2":
version: 8.0.4
resolution: "minimatch@npm:8.0.4"
dependencies:
brace-expansion: "npm:^2.0.1"
checksum: 10c0/a0a394c356dd5b4cb7f821720841a82fa6f07c9c562c5b716909d1b6ec5e56a7e4c4b5029da26dd256b7d2b3a3f38cbf9ddd8680e887b9b5282b09c05501c1ca
languageName: node
linkType: hard

"minimatch@npm:^9.0.4":
version: 9.0.4
resolution: "minimatch@npm:9.0.4"
"minimatch@npm:^8.0.6":
version: 8.0.7
resolution: "minimatch@npm:8.0.7"
dependencies:
brace-expansion: "npm:^2.0.1"
checksum: 10c0/2c16f21f50e64922864e560ff97c587d15fd491f65d92a677a344e970fe62aafdbeafe648965fa96d33c061b4d0eabfe0213466203dd793367e7f28658cf6414
checksum: 10c0/46d9dee24174f8a9eadec97ba36cba2e63f1fff8b36324e1825229bd9307ffee7ffd2f5a2749b29ba796eda877cd9c1687f9d1b399a10b290346561f2a8145f8
languageName: node
linkType: hard

"minimatch@npm:^9.0.5":
"minimatch@npm:^9.0.5, minimatch@npm:^9.0.7":
version: 9.0.9
resolution: "minimatch@npm:9.0.9"
dependencies:
Expand Down Expand Up @@ -25180,13 +25148,6 @@ __metadata:
languageName: node
linkType: hard

"picomatch@npm:^4.0.2, picomatch@npm:^4.0.3":
version: 4.0.3
resolution: "picomatch@npm:4.0.3"
checksum: 10c0/9582c951e95eebee5434f59e426cddd228a7b97a0161a375aed4be244bd3fe8e3a31b846808ea14ef2c8a2527a6eeab7b3946a67d5979e81694654f939473ae2
languageName: node
linkType: hard

"picomatch@npm:^4.0.4":
version: 4.0.4
resolution: "picomatch@npm:4.0.4"
Expand Down Expand Up @@ -25841,42 +25802,22 @@ __metadata:
languageName: node
linkType: hard

"protobufjs@npm:^7.5.5":
version: 7.6.2
resolution: "protobufjs@npm:7.6.2"
"protobufjs@npm:^7.6.3":
version: 7.6.6
resolution: "protobufjs@npm:7.6.6"
dependencies:
"@protobufjs/aspromise": "npm:^1.1.2"
"@protobufjs/base64": "npm:^1.1.2"
"@protobufjs/codegen": "npm:^2.0.5"
"@protobufjs/eventemitter": "npm:^1.1.1"
"@protobufjs/fetch": "npm:^1.1.1"
"@protobufjs/float": "npm:^1.0.2"
"@protobufjs/inquire": "npm:^1.1.2"
"@protobufjs/path": "npm:^1.1.2"
"@protobufjs/pool": "npm:^1.1.0"
"@protobufjs/utf8": "npm:^1.1.1"
"@types/node": "npm:>=13.7.0"
long: "npm:^5.3.2"
checksum: 10c0/3c552dfe3cbcfad2d6c312a76cd189cf5be9fb36b203f6292f79c6020d675f7f33d5531ce312441c42ae75deb24ced32760e64fe4aa3d5b3c2295fd67cea270c
languageName: node
linkType: hard

"protobufjs@npm:^7.6.5":
version: 7.6.5
resolution: "protobufjs@npm:7.6.5"
dependencies:
"@protobufjs/aspromise": "npm:^1.1.2"
"@protobufjs/base64": "npm:^1.1.2"
"@protobufjs/codegen": "npm:^2.0.5"
"@protobufjs/eventemitter": "npm:^1.1.1"
"@protobufjs/fetch": "npm:^1.1.1"
"@protobufjs/float": "npm:^1.0.2"
"@protobufjs/path": "npm:^1.1.2"
"@protobufjs/pool": "npm:^1.1.0"
"@protobufjs/utf8": "npm:^1.1.1"
"@types/node": "npm:>=13.7.0"
long: "npm:^5.3.2"
checksum: 10c0/863eaca9c6f45bfcfb8787c545f53e9c6696507e328e3981b4643c12d35df7f2826021c10e3fd30bef342c13a8e9d306547bac9c0849ee3bf50f770a12f01dc5
checksum: 10c0/6c0dc6d4a2801825e39417bc116297d5261c0cf28892a5e28adafc13432331c0cb75603bbe50ad6f2715f3b0a9ce2896591ad6b51fdc8eae2d05b9ac2e4a8ec1
languageName: node
linkType: hard

Expand Down Expand Up @@ -25965,31 +25906,13 @@ __metadata:
languageName: node
linkType: hard

"qs@npm:6.15.1":
version: 6.15.1
resolution: "qs@npm:6.15.1"
dependencies:
side-channel: "npm:^1.1.0"
checksum: 10c0/19ee504f0ebff72598503e38cd6d9bd7b52a8ab62ae18b1e6bee3d4db58469bd65871ef1893a881bafb0f80ef2f9ab586e1f255cf25cc8d816c0f5a704721d97
languageName: node
linkType: hard

"qs@npm:^6.11.0, qs@npm:^6.11.2, qs@npm:~6.14.0":
version: 6.14.2
resolution: "qs@npm:6.14.2"
dependencies:
side-channel: "npm:^1.1.0"
checksum: 10c0/646110124476fc9acf3c80994c8c3a0600cbad06a4ede1c9e93341006e8426d64e85e048baf8f0c4995f0f1bf0f37d1f3acc5ec1455850b81978792969a60ef6
languageName: node
linkType: hard

"qs@npm:~6.15.1":
version: 6.15.3
resolution: "qs@npm:6.15.3"
"qs@npm:^6.16.0":
version: 6.17.1
resolution: "qs@npm:6.17.1"
dependencies:
es-define-property: "npm:^1.0.1"
side-channel: "npm:^1.1.1"
checksum: 10c0/8f3f6e45ece255347d57696628401cde29e9ec649fff698b53bd3150dea7cefdf33036e1bc1826b9f110bfa7cb0ec4ab9f5297eca628ce216c55af82c304e08e
checksum: 10c0/55f09dd0282fda70ce9475719158f910f2214477b95aa7284675fb9977c9cdae89fb495423399227331de76766703aaa71372e96cded05046e21713c033e885d
languageName: node
linkType: hard

Expand Down Expand Up @@ -28237,17 +28160,10 @@ __metadata:
languageName: node
linkType: hard

"smol-toml@npm:1.6.1":
version: 1.6.1
resolution: "smol-toml@npm:1.6.1"
checksum: 10c0/511a78722f99c7616fdb46af708de3d7e81434b5a3d58061166da73f28bfc6cae4f0cd04683f60515b9c490cd10152fce72287c960b337419c0299cc1f0f2a22
languageName: node
linkType: hard

"smol-toml@npm:^1.6.1":
version: 1.7.0
resolution: "smol-toml@npm:1.7.0"
checksum: 10c0/8eef246b9b96f278a181f6dd2a90c754304cb4cf92ccdfe1d2f714fb980fb3f539ba00283609e8fd2fbcf7c0d48a4ae76b36bc0de556ed286b2c865827a778e8
"smol-toml@npm:^1.6.1, smol-toml@npm:^1.8.0":
version: 1.9.1
resolution: "smol-toml@npm:1.9.1"
checksum: 10c0/8acccf7bbc063f29405f58f5014ab39bf4eb9d7f0e000e5e3f140f7d4d6ead5696681a7c15260d1f2910213012c0af43b31a05bf94f704b0bdf39989fba08c02
languageName: node
linkType: hard

Expand Down
Loading