Repository navigation
Conversation
`yarn npm audit` flags lodash, qs, minimatch, picomatch, protobufjs, @hono/node-server and smol-toml copies that consumers pin below the fixed version. Each floor stays within the major version the consumer asked for, so no consumer moves to a new major. Also refresh the stale smol-toml `^1.6.1` lock entry.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
| "minimatch@^10.2.2": "^10.2.3", | ||
| "picomatch@^4.0.2": "^4.0.4", | ||
| "picomatch@^4.0.3": "^4.0.4", | ||
| "@hono/node-server": "^1.19.13", |
There was a problem hiding this comment.
🔵 minor — Overrides for @hono/node-server, protobufjs and qs apply to every version range, so a later 2.x/8.x/7.x request would be forced back down
Limit these to the ranges actually requested today, as the minimatch/picomatch lines do: "@hono/node-server@^1.19.9": "^1.19.13", "protobufjs@^7.5.5"/"protobufjs@^7.6.5", and the qs ranges ~6.14.0/^6.11.0/^6.11.2/6.15.1/~6.15.1. As written, "@hono/node-server": "^1.19.13" replaces every request for the package. Today the only request is npm:^1.19.9 from @modelcontextprotocol/sdk (yarn.lock ~6513). When that SDK moves to @hono/node-server@^2, which the PR says is needed for GHSA-rmxm-3fg6-px4f, Yarn will quietly install 1.x instead and the advisory stays unfixed. The blanket protobufjs and qs overrides would do the same to any future 8.x or 7.x request.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
| "@types/express": "4.17.21", | ||
| "@types/express-serve-static-core": "4.17.43", | ||
| "express": "^4.20.0", | ||
| "lodash": "4.18.1", |
There was a problem hiding this comment.
🔵 minor — The lodash override is an exact version, not a minimum like the other entries
Change it to "lodash": "^4.18.1". The exact 4.18.1 forces every lodash request to that version, including the workspace's own ^4.18.1 requests (yarn.lock ~4819/4938/5042). If a later 4.18.x or 4.19.x security release comes out, or a dependency starts asking for one, Yarn will still install 4.18.1 and yarn up cannot move it.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor 2 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
E2E Test Results✅ All tests passed • 464 passed • 1 skipped • 1057s
Tests ran across 4 shards in parallel. |
Deep Review✅ No critical issues found. This is a root One cross-reviewer claim — that 🟡 P2 -- recommended
🔵 P3 nitpicks (1)
Reviewers (5): correctness, security, maintainability, project-standards, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
Summary
Add
resolutionsfloors for advisories thatyarn npm auditreports in transitive dependencies. Each floor stays within the major version the consumer requested, so no package is moved to a new major.lodash→ 4.18.1~4.17.xconsumers were on 4.17.23)qs→^6.16.0minimatch3.x / 8.x / 9.x / 10.x descriptorspicomatch@^4.0.2,^4.0.3→^4.0.4protobufjs→^7.6.3@hono/node-server→^1.19.13smol-toml@1.6.1→^1.8.0, plus a refreshed^1.6.1lock entryBefore and after
yarn npm audit -A -R: 14 advisories cleared, none added.Not covered here, because the fix needs a new major or a direct dependency bump: minimatch GHSA-g3hv-75wg-m249 (needs 11.x),
@hono/node-serverGHSA-rmxm-3fg6-px4f (needs 2.x), and the advisories on direct dependencies such asaxiosand@modelcontextprotocol/sdk.How to test locally or on Vercel
yarn installyarn npm audit -A -R: the advisories in the table no longer appear.make ci-lintandmake ci-unit: both pass.Root manifest and lockfile only, so no changeset.
🤖 Generated with Claude Code