Repository navigation
Windows parity: test_dev_engine_pin.py in WINDOWS_NOT_APPLICABLE, and a guard that the two exclusions agree - #308
Merged
Conversation
… a guard that the two exclusions agree (closes #307) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ritten by a later fallback; release workflows refuse a wheel that does not state its engine Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307
test_dev_engine_pin.pywas excluded on Windows only throughcollect_ignore, which the native parity runner does not honour for a file it names on the command line. It runs the bash code of a workflow step, so it failed on the Windows parity legs of 26.12.1.dev0 and the gate held the nativewin_amd64wheel back (dev0 is on PyPI without it: no win_amd64arcadedbwheel; the three other native platforms and allarcadedb-jvmwheels are published).test_dev_engine_pin.pymoves intoWINDOWS_NOT_APPLICABLE, the tableparity_wheel.pyreads, and out of the separatecollect_ignore.append.New
tests/test_conftest_windows_table.pyruns everywhere and parsesconftest.pywithast: every file appended tocollect_ignorein the win32 block must be a key of the table, every key must exist, andparity_wheel.pymust still read and apply the table. I ran its functions by hand against this conftest (pass) and against the previous one (it namestest_dev_engine_pin.py).26.12.1.dev1 will carry this fix; the engine pin is unchanged.
The native 26.12.1.dev0 wheel recorded the pinned snapshot in
_build_info.py, butarcadedb.ENGINE_SNAPSHOTandarcadedb.ENGINE_IMAGE_DIGESTprinted None:build_wheel.pyimports them near the top of__init__.py, and the JVM fallbacktry/exceptfurther down set them to None again.__init__.pynow looks in_build_infofirst, andtests/test_engine_snapshot_recorded.py(it runs in the native parity legs on the installed wheel) asserts that the attribute is the recorded value on both builds.scripts/verify_wheel_engine_pin.pyruns inrelease-native.yml(verify job, before the upload) andrelease-jvm.yml(verify-wheels): a.devNwheel must record the pinned snapshot and image digest in its_build_info.pyor_version.py, a final or.postNwheel must record none. A release can no longer publish a wheel that does not say what it embeds.🤖 Generated with Claude Code