Repository navigation
Dev release: Maven resolves the pinned timestamped snapshot; the facets example prints no varying count - #310
Merged
Merged
Conversation
…check compares the pinned jars, the facets example does not print a varying count (closes #309) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…inked (file names carry the base version), manage bolt, postgresw and redisw Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
26.12.1.dev1is an unpublished tag: its release failed before any upload (native: the pin check after the build, JVM: one flaky docs test).26.12.1.dev0stays on PyPI as it is: it has no nativewin_amd64wheel (the Windows parity jobs failed on a test that #308 fixed) and its native wheel printedENGINE_SNAPSHOT None(also fixed in #308).26.12.1.dev2is the next release.Native, root cause:
native/pom.xmltook-Darcadedb.version=26.12.1-SNAPSHOT, which Maven resolves to the newest Sonatype build at build time, and engine and server list their sibling modules at the floating version too..devNrelease now passes the pinned timestamped snapshot (26.12.1-20261106.183100-26) to Maven (maven-engineoutput of the plan step, used asARCADEDB_ENGINE_VERSION);enginestays26.12.1-SNAPSHOTfor the checks, and the wheel still recordsENGINE_VERSION,ENGINE_SNAPSHOTandENGINE_IMAGE_DIGEST. A manual run can name one with the newmaven-engineinput (only for a SNAPSHOT engine of the same base).native/pom.xmlmanages the othercom.arcadedbmodules (console, graphql, grpc, integration, mcp) at${arcadedb.version}, so a transitive one cannot float.dev_engine_pin.py checkcompares the pinned timestamped jars on Sonatype, not the newest ones, so it no longer fails when upstream deploys. I checked with HEAD that the jar and pom of all nine modules exist at the pinned timestamp; the check passes now although build 28 is the newest.build.logand fails whenarcadedb-engine-<snapshot>.jaris not on the classpath or anyarcadedb-*jar there is another version.arcadedb-parent:26.12.1-SNAPSHOT) that the engine pom names still resolves to the newest one, so a third-party version that only the parent manages can move;native/pom.xmlalready manages the versions the wheel ships.JVM flake: the
TERMScount of the other facet in the unavailable-hierarchy example was3once and6otherwise. I could not reproduce it (0 of 350 fresh databases, native and JVM dev0 wheels: always sourcescan, count 6), so I cannot say if it is a lagging index or an engine race. The page block andtest_unavailable_facet_is_surfacedno longer print or assert that count, they check the facet's type and that its source isindexorscan, and the page says a count is read with itssourceandmeta. The open engine question goes to the maintainers separately.Tests:
tests/test_dev_engine_pin.pyruns the real plan step for themaven-enginecases (the timestamp is refused for a final release, for a release engine and for another base).🤖 Generated with Claude Code