Skip to content

fs.readdirSync on a file: ENOTDIR on Windows, not EINVAL #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASDAlexander77 merged 1 commit into from
Nov 11, 2026
Merged

fs.readdirSync on a file: ENOTDIR on Windows, not EINVAL #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/wrappers/os.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,14 @@ extern "C" TSLANG_EXPORT int tslang_fs_read_dir(const char *path)
fs::directory_iterator it(to_path(path), ec);
if (ec)
{
// Windows says ERROR_DIRECTORY for a file, which MSVC maps to EINVAL; Node says ENOTDIR
std::error_code statError;
auto status = fs::status(to_path(path), statError);
if (!statError && fs::exists(status) && !fs::is_directory(status))
{
return fail_errc(std::errc::not_a_directory, "scandir", path);
}

return fail(ec, "scandir", path);
}

Expand Down
Loading