Repository navigation
fs.readdirSync on a file: ENOTDIR on Windows, not EINVAL - #91
Merged
Merged
Conversation
Windows gives ERROR_DIRECTORY for a directory iterator opened on a file, which MSVC maps to EINVAL; Node says ENOTDIR. tslang_fs_read_dir now checks for an existing non-directory when the listing fails and reports ENOTDIR. fs.ts's "list a file" failed on every Windows job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tslang_fs_read_dir(src/wrappers/os.cpp) now reportsENOTDIRwhen the path is an existing file that isn't a directory, as Node does.Why
On Windows, opening a directory iterator on a file fails with
ERROR_DIRECTORY, which MSVC'sstd::system_categorymaps toEINVAL.tests/fs.tsexpectsENOTDIR(orENOENT) in its "list a file" check, so it failed on every Windows job (EINVAL: invalid argument, scandir '...'). Linux already reportsENOTDIR, so nothing changes there.Notes for the reviewer
-mm=gc, both compiled and under the JIT:fs,process,process_exit,array_flat,map_groupByandstring_fromCodePointall print ALL DONE.abort(), which opens a modal dialog that nobody closes. This fix stops that assert from failing.🤖 Generated with Claude Code