Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex can ask for confirmation on a command such as
rm -funder T3's default Full Access policy. T3 displays an approval card and pauses the thread, including unattended delegates.Change
T3 accepts the one-time command confirmation when the turn uses the default Full Access policies, Codex offers exactly
acceptandcancel, and the request carries no reason, permission request, or policy proposal. The client preserves the decision list and extra-permission field from the Codex wire request. Missing decision lists, terminal input, shell-bridge callbacks, and managed-network approvals follow the existing approval flow.Scope
This fork rewrite addresses the Full Access command approval issue. It draws on the command-only fix and the alternative approval handling. The patch covers command confirmations.
Verification
vp run check:changed 6f5293fbdca4 --concurrency 2passed, including 229 tests. The Codex 0.171 schema confirmed the approval fields. Verification used recorded requests and did not start a live model turn.Implemented with GPT-6.2 Sol in Codex.