Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zrm625
force-pushed
the
pyre/ghes-stack-fields
branch
from
November 8, 2026 18:19
794dbf0 to
d2dec1f
Compare
Enterprise Server validates a whole GraphQL document before applying directives, so the listing and summary documents fail there because they name `stack` and `stackEntry`, even under `@include(if: false)`. Enterprise hosts now get documents without those fields, and github.com gets `PullRequestSearchWithStacks` and `PullRequestSummaryWithStacks`, which share one `PullRequestStackFields` fragment with `PullRequestStackMembership`. Co-authored-by: felixlaga <felix.laga@yahoo.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zrm625
force-pushed
the
pyre/ghes-stack-fields
branch
from
November 9, 2026 13:18
d2dec1f to
0b5c51a
Compare
zrm625
added a commit
that referenced
this pull request
Nov 9, 2026
Keep stack and label coverage together, and regenerate GraphQL operations with the current watch fields. Model: gpt-6.1-sol. Harness: Codex in T3 Code.
Model: gpt-6.1-sol. Harness: Codex in T3 Code.
Share the summary request call and search arguments across GitHub and Enterprise while preserving their existing GraphQL documents and batching. Model: gpt-6.1-sol. Harness: Codex in T3 Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub Enterprise Server, the Pull Requests tab is empty and linked pull request summaries fail with
Field 'stack' doesn't exist on type 'PullRequest'. Enterprise Server validates the full GraphQL document before applying@include, so gatingstackandstackEntrybehind@include(if: $stacks)still causes every listing and summary read to be rejected (pingdotgg/t3code#20436).Fix
PullRequestStackFieldsfragment used only bygithub.comoperations (PullRequestSummaryWithStacks,PullRequestSearchWithStacks, andPullRequestStackMembership).PullRequestSummary,PullRequestSearch, andPullRequestListfree of stack fields so Enterprise Server hosts never receive them, whilegithub.commakes the same requests as before.isGitHubCom(host)check, and only decode stack fields on rows that carry them.graphql.config.tsto note that Enterprise-missing fields belong in separategithub.com-only documents rather than under@include.GitHubPullRequestApitests to verifyPullRequestSearchWithStacksongithub.comand confirm Enterprise list, search, and summary reads never name stack fields or trigger stack enrichment.Validation
vp run check:changedpasses (format, lint, knip,graphqlgen --check, typecheck across 11 packages, and 194 tests).Based on
@felixlaga's original fix inpingdotgg/t3code#20531(credited as co-author).Implemented with Claude Opus 5.5 (Claude Code) and Gemini 4 Neon (Antigravity) through T3 Code.