Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thread transfer impact
This comment will update automatically after the next completed run. |
zrm625
force-pushed
the
pyre/installable-mcp-plugin
branch
from
November 8, 2026 18:19
06cf619 to
9525bc8
Compare
Some workplaces deploy a Codex admin policy that allows MCP servers only from approved plugins. That policy refuses the MCP servers T3 Code puts in each thread's config, so Codex threads lose every T3 Code tool. t3-codex fixes this without changing how T3 Code talks to Codex. T3 Code's Codex binary path points at it. It runs the real app-server, moves T3 Code's per-thread servers out of thread config, and serves them through a T3 Code plugin whose bridge pipes to it. Each tool call still uses the calling thread's own credential; subagents act as their parent thread. T3 Code also gains an opt-in T3CODE_MCP_SOCKET that serves /mcp, and only /mcp, on an owner-only Unix socket for hosts that forbid loopback MCP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The same plugin-only policies exist for Claude Code: they refuse the MCP server T3 Code adds through the Agent SDK's setMcpServers, so Claude threads lose T3 Code's tools too. The crate becomes t3-mcp-plugin and builds t3-codex and t3-claude. T3 Code's Claude binary path points at t3-claude, which moves the t3-code server out of mcp_set_servers (also on rotation) and serves it through the plugin. Claude runs one process per thread, so every call uses that thread's credential. Claude names plugin tools differently, so t3-claude maps them back to mcp__t3-code__* for T3 Code's allowed tools, approvals and tool rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The socket now shares the main router through one HttpServer instead of
passing raw requests along with emit("request"). Startup checks use
FileSystem and a typed McpSocketError.
Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.
Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.
Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.
Drops tests of a case T3 Code never produces, trivial parsing checks, and a wall-clock wait. The Codex and Claude rewrites are each tested once, message in to message out. The test-only Stdin constructor goes: pending replies are their own type. The socket module follows the server's Effect style. Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.
Runs T3 Code's real codexThreadRuntimeParams and claudeMcpQueryOverrides against fixtures the Rust wrappers parse, and checks the plugin's server settings against them. Unrelated thread config changes don't affect it. Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.
…'s helpers T3_MCP_SOCKET read too much like T3 Code's T3CODE_MCP_SOCKET, so the wrapper's bridge channel is now T3_MCP_BRIDGE. One lock helper and one runtime builder replace the copies in each module, and an error shared by both wrappers no longer names t3-codex. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zrm625
force-pushed
the
pyre/installable-mcp-plugin
branch
from
November 9, 2026 13:18
9525bc8 to
c7144db
Compare
zrm625
added a commit
that referenced
this pull request
Nov 9, 2026
Preserve the plugin and Unix socket support while incorporating current upstream changes. Model: gpt-6.1-sol. Harness: Codex in T3 Code.
Model: gpt-6.1-sol. Harness: Codex in T3 Code.
Sync with fork main, drop the optional MCP HTTP listener and wrapper socket override, and match the Codex marketplace configuration to the current direct tool list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some workplaces allow MCP servers only from approved plugins. Under those policies, Codex and Claude Code reject the MCP server T3 Code passes to each thread, leaving those threads without T3 Code tools.
This adds the
t3-code@t3marketplace plugin and two provider wrappers,t3-codexandt3-claude. The plugin talks to the wrappers, which forward calls to the existing loopback HTTP endpoint with the calling thread's credential. Codex routest3_thread_waitanddelegate_taskthrough the direct registration, matching T3 Code's current tool settings. The plugin README covers installation and credential handling.The updated head passed
vp run check:changed(211 tests), all seven Rust tests, rustfmt, and Clippy. Codex 0.171.0 and Claude Code 2.1.330 both installed the local marketplace plugin in temporary profiles. Both wrappers completed authenticated MCP tool calls against a loopback test server with mock providers. Live managed-policy turns were exercised on the earlier Linux implementation. The updated head was tested on Linux.Implemented with Claude Opus 5.5 in Claude Code and updated with GPT-6.2 Sol in Codex, through T3 Code.