[sodre]

Fixes from the second code review, over 6dbaa56..c137ee0. Review findings #5 (shapeOf spells out its defaults) and #6 (the hand-launch copies the fleet options) were accepted as they are and not changed here.

Summary

One commit per finding. Behaviour doesn't change.

 functions/launcher.js
-  tagsOf(tags)  -> { 'ci-runner:capacity': ..., 'ci-runner:vcpus': ... }
+  tagsOf(tags)  -> { capacity: ..., vcpus: ... }     # strips the prefix, like the webhook's and notifier's
-  t['ci-runner:capacity'], t['ci-runner:vcpus']
+  t.capacity, t.vcpus

 functions/webhook.js
-  // The shape of an instance launched before the shape tags.
+  // The shape of an instance or task launched before the shape tags, which
+  // swap repair re-queues with it. The launcher carries a copy.
-  const wire = { label: shape.capacity, vcpus, arch }
+  const queuedShape = { label: shape.capacity, vcpus, arch }   # comment on `label` kept

 test/conventions.test.js
+  test: launcher, webhook and notifier tagsOf are identical
+  test: launcher and webhook DEFAULT_SHAPE are identical

 test/launcher.test.js
-  fakeEcs({ running })
+  fakeEcs({ tasks })       # some are told to stop, or STOPPED

Evidence

• Before: make test: 144 pass. The launcher's tagsOf and the webhook's DEFAULT_SHAPE could drift apart with no test failing.
  After: make test: 146 pass, and it passes after each commit. If any tagsOf copy or either DEFAULT_SHAPE differs, the new tests fail. make build: 74295 of 1048576 bytes.

Merge Danger

Door: two-way

Renames and comments, plus the launcher reading the same two tags under their stripped keys. Revert to roll back. Nothing needs deploying.

Blast Radius: launcher-budgets

If the launcher reads capacity/vcpus wrongly, the vCPU budgets count wrong. The existing budget tests cover both the EC2 and Fargate paths.

🤖 Generated with Claude Code