Repository navigation
fix(deps): enforce patched node-forge resolutions - #757
Merged
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
bhabalan
marked this pull request as ready for review
November 11, 2026 08:40
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rsarika
approved these changes
Nov 11, 2026
rarajes2
approved these changes
Nov 13, 2026
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #CVE-2026-85393
This pull request addresses
Widgets repository installs currently select
node-forge@1.3.1through the SDK'snode-josedependency and the development server'sselfsigneddependency. This version predates the RSA signature-verification fixes for CVE-2026-85393.by making the following changes
"node-forge": "^1.4.3"to the rootpackage.jsonresolutions.yarn.lockto select Forge 1.4.3 and its checksum. The manifest sets the minimum version for future repository installs; the lockfile records the exact version used by the build.The widget keeps
webexexternal. Host applications must update their own lockfiles because root resolutions are not inherited by published package consumers.Related PRs: SDK #5373 applies the same Forge requirement. Interfaces #181 removes the separate production dependency paths to
timespanandinflight; that fix requires an interfaces package release.Change Type
The following scenarios were tested
Using Node 22.14.0:
yarn install --immutable: passed.yarn workspace @webex/widgets test:unit --runInBand: passed, 30 tests, with the repository Jest binary on PATH.yarn workspace @webex/widgets build:src: passed.yarn build:dev: passed for all repository packages.yarn run test:unitandyarn run test:styles. The style check reported 6 existing warnings and no errors.node-joseand Forge dependencies: PEM Buffer import, RSA signing and verification, JWE encryption/decryption, and rejection of malformed nested DigestInfo data passed.package.json.Full repository CI is pending code-owner validation through the
validatedlabel. Manual testing on the Amplify preview and live KMS integration tests were not run.The GAI Coding Policy And Copyright Annotation Best Practices
AI assistance: OpenAI Codex generated the manifest change, dependency baseline documentation, and this description. Yarn generated the lockfile. Existing source copyright notices were preserved.
Checklist before merging
The full-test and Amplify checklist items remain open until those checks are complete. The dependency baseline was updated; a separate testing document was not updated.
Make sure to have followed the contributing guidelines before submitting.