Repository navigation
Conversation
willymv
marked this pull request as ready for review
November 8, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect lighting rendering because of Dynmap replacing a chunks light data.
Minecraft's chunk status values now contain the "minecraft:" prefix and chunks generated on a Paper server have their "isLightOn" set to false for every chunk. Either one of these cause the if statement to pass, forcing dynmap to replace all the light values and ignore the chunks actual light data.
Every chunk generated from Paper has Starlight data in it, making it pretty easy to determine if the "isLightOn" value can be trusted.
If light data is actually wrong in the chunk data for whatever reason, it will continue to render with sharp looking shadow. I don't believe this is a Dynmap issue.