Repository navigation
Bump vcell_submodule to vcell#2206: SBML import of L3V2 features, refusals instead of wrong results - #33
Merged
Conversation
…, refusals) vcell-core now imports SBML elements with no math, the rateOf csymbol, 0-D compartments, L3V2 MathML (quotient, rem, implies; n-ary xor/max/min; nullary operators) and math with no ODEs (a placeholder state variable in the ODE input); it refuses comp/multi/arrays/distrib documents and conversion factors instead of importing them wrong. Tests cover the new paths and the comp refusal through the native library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
compose-api runs VCell's ODE solves on the SBML Test Suite through pyvcell → libvcell. vcell#2206 (merged,
fab94ed) fixes the import gaps that made most of them fail; this brings it into the native library for the next release (0.0.25, already the version onmain).What
vcell_submodule→fab94ed(vcell#2206). vcell-core now imports SBML elements with no math (no effect in L3V2), therateOfcsymbol, 0-dimensional compartments, L3V2 MathML (quotient,rem,implies; n-aryxor/max/min; nullary operators) and math with no ODEs (OdeFileWriterwrites a placeholder state variable__vcell_no_ode__); it refusescomp/multi/arrays/distribdocuments and conversion factors, which it used to import wrong.rateOf,quotientand a math-less rule converts to VCML and to ODE solver input (it has a rate rule as its only ODE); acompmodel is refused with a message naming the package.vcell#2206 passed vcell's regression gate (MathGen, SBML, SED-ML, BSTS, Geometry, Oracle) before merging.
🤖 Generated with Claude Code