[Copilot]

GitHub Copilot informed me about a bug in vimcheck so I asked it to fix it. The bug report was:

basic_burden_sanity() errors with "the condition has length > 1" whenever any check produces a warning, because of if (mes == mes_start) comparing a vector (an error since R ≥ 4.2). It's worth a fix upstream in vimc/vimcheck.

I don't speak R so would appreciate a review.

Copilot's PR description

Bug validation

Confirmed on R 4.3.3: missing values, negative estimates, non-numeric estimates, and combined missing/negative estimates each produce the condition has length > 1. Clean numeric estimates return the header and PASS..

This is a bug, not an intentional rejection of invalid estimates. The documented return value is a character vector of check messages, and the function explicitly accumulates those messages. These are strings prefixed with Warning:, not emitted R warning conditions. Once a failed check appends a message, mes == mes_start is a logical vector rather than the scalar required by if. On older R versions, using its first (always TRUE) element also incorrectly appends PASS. alongside failed-check messages.

Changes

• Replace the vector comparison with identical(mes, mes_start) so PASS. is appended only when no failed-check messages were added.
• Preserve existing diagnostic wording, ordering, checks, and clean-input behaviour.
• Add regression coverage for clean numeric/integer/empty estimates; missing values including NaN; negative and non-numeric estimates; and simultaneous missing/negative values. Assert exact output and absence of emitted conditions.
• Document the fix in NEWS.md.

Validation

The full tests/testthat/test-burden_diagnostics.R file passes on R 4.3.3 (36 expectations), with repository R sources and example data loaded. git diff --check passes.

Review requested from @kgaythorpe and @david-mears-2.

[david-mears-2]

@copilot You should increment the patch version when you do a bugfix. Increment it and document this requirement.

[Copilot]

@copilot You should increment the patch version when you do a bugfix. Increment it and document this requirement.

Bumped DESCRIPTION to 0.0.6 and documented the patch-version rule in CONTRIBUTING.md. Commit: c9f8b88.