Skip to content

#809469 check the schema id - #40

Merged
dorislinda merged 2 commits into
mainfrom
feature/809469-no-schema-id
Nov 9, 2026
Merged

dorislinda merged 2 commits into
mainfrom
feature/809469-no-schema-id

Conversation

@dorislinda

Copy link
Copy Markdown
Collaborator

schema id should have a value

Copilot AI balanced review requested due to automatic review settings November 8, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing tests omit the now-required schema_id, causing failures or bypassing intended validation, while README examples still describe an incompatible API contract.

2 open issues
What changed in this PR

This PR makes a schema ID mandatory when saving datasets to the Data Catalogue, enforcing the requirement before storage or registration begins.

Changes:

  • Makes schema_id a required uuid.UUID argument.
  • Adds runtime validation to reject missing values such as None and incorrect types.
  • Updates the method’s documentation and example to use a UUID object.
File Description
src/​dataworkbench/​datacatalogue.py Requires and validates schema IDs in save() and updates its documentation.

Review effort: Balanced

Comment thread src/dataworkbench/datacatalogue.py Outdated
dataset_name: str,
dataset_description: str,
schema_id: uuid.UUID | None = None,
schema_id: uuid.UUID,
Comment thread src/dataworkbench/datacatalogue.py Outdated
dataset_name: Name of the dataset for the catalog
dataset_description: Description of the dataset's purpose and contents
schema_id: Optional UUID for the dataset's schema
schema_id: UUID for the dataset's schema
@dorislinda
dorislinda merged commit 35fdd63 into main Nov 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants