Skip to content

Preserve Gateway validation details for missing schema ID - #39

Merged
hanyfakhry merged 2 commits into
mainfrom
finding/809469-give-proper-exception-on-no-schema-id
Oct 28, 2026
Merged

hanyfakhry merged 2 commits into
mainfrom
finding/809469-give-proper-exception-on-no-schema-id

Conversation

@micsoko

@micsoko micsoko commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 08:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated failure test always supplies a non-empty detail, leaving the new errors fallback untested, with multiple-entry, correlation-ID, and trace-only coverage still needed.

1 open issue
What changed in this PR

This PR preserves Gateway validation details when dataset import fails because a schema ID is missing, while retaining the correlation ID for troubleshooting.

Changes:

  • Include response detail, or field-level errors as a fallback, in import exceptions.
  • Update Gateway tests to check validation details and the correlation ID.
  • Verify that DataCatalogue preserves the validation message when triggering rollback.
File Description
tests/​test_gateway.py Checks missing-schema validation details in import exceptions.
tests/​test_datacatalogue.py Checks validation-message preservation during rollback.
src/​dataworkbench/​gateway.py Extracts validation details and includes them alongside the correlation ID.

Review effort: Balanced

Comment thread src/dataworkbench/gateway.py Resolved
Co-authored-by: micsoko <175594233+micsoko@users.noreply.github.com>
@hanyfakhry
hanyfakhry merged commit 82ff5b0 into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants